Skip to content

Commit

Permalink
Update version of golangci-lint for Go1.18
Browse files Browse the repository at this point in the history
The pinned version of golangci-lint was out of date and failing when
running with Go 1.18. This changes bumps the version to the version
being used by Packer.
  • Loading branch information
nywilken committed Aug 10, 2022
1 parent 5fd5672 commit c8f839c
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions Makefile
Expand Up @@ -16,9 +16,8 @@ install-gen-deps: ## Install dependencies for code generation
@go install github.com/hashicorp/packer-plugin-sdk/cmd/packer-sdc

install-lint-deps: ## Install linter dependencies
# Pinning golangci-lint at v1.23.8 as --new-from-rev seems to work properly; the latest 1.24.0 has caused issues with memory consumption
@echo "==> Updating linter dependencies..."
@curl -sSfL -q https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(GOPATH)/bin v1.23.8
@curl -sSfL -q https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(GOPATH)/bin v1.42.0

lint: install-lint-deps ## Lint Go code
@if [ ! -z $(PKG_NAME) ]; then \
Expand Down

0 comments on commit c8f839c

Please sign in to comment.