UI: Update ember-a11y-testing #9912
Conversation
This was originally in #9641 but became problematic so I decided to update it in (relative) isolation.
backspace
added
theme/ui
theme/dependencies
Ember Asset Size actionAs of 1982358 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
This fixes test failures such as this one: https://app.circleci.com/pipelines/github/hashicorp/nomad/14501/workflows/01177cd9-a2ae-4fff-94ef-6b109b778123/jobs/134238#failed-test-54 One of the nested dependencies must have changed but I wasn’t able to track it down. 😖
This fixes all the test failures seen here apart from the job adapter ones: https://app.circleci.com/pipelines/github/hashicorp/nomad/14501/workflows/01177cd9-a2ae-4fff-94ef-6b109b778123/jobs/134238 This was last toggled in #8035 and it’s frustrating to have to change it back but I couldn’t find another way 😞
backspace
force-pushed
the
f-ui/ember-a11y-testing-v4
branch
from
6b0c14c
to
1982358
Compare
I’ve deleted the above comment because I deliberately pushed with failures, but wanted to note that the flakiness report worked 🤩 |
|
Oof. What a journey! |
| @@ -60,7 +60,7 @@ export default class Watchable extends ApplicationAdapter { | |||
| signal, | |||
| data: params, | |||
| }).catch(error => { | |||
| if (error instanceof AbortError) { | |||
| if (error instanceof AbortError || error.name == 'AbortError') { | |||
There was a problem hiding this comment.
Hmm. These make me sad, but they're definitely not the end of the world. I think I'll open an issue tracking this particular thing. I wouldn't want to block the Ember and related deps work on it.
There was a problem hiding this comment.
ya, I don’t love it, a new issue sounds good to me so I can proceed through this slog 😆💞
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This was originally in #9641 but it became quite involved as described below, so I decided to update it in (relative) isolation.
I needed to update
ember-a11y-testingbecause of failures with Ember 3.20 such as this. The new version has a peer dependency on@ember/test-helpersv2 and we only had various v1s through other addons.The
ember-fetchupdate is because of this.It’s hard to see because
yarn.lockthrashing is the only evidence, but I also had torm -rf node_modules yarn.lockto fix a catastrophic Babel error discussed here. I much prefer targeting specific dependencies for updates but I couldn’t determine which ones were the problem so I did as suggested in that thread 😞See 9ee5c96 and 1982358 for comments on specific changes.
It seems pretty minimal but it took me surprisingly long to get to this point 😭