ci: use the same go mod cache across test-core jobs #15006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
changed the title
tgross
reviewed
Oct 21, 2022
| @@ -58,22 +72,23 @@ jobs: | |||
| - uses: magnetikonline/action-golang-cache@v1 | |||
| with: | |||
| go-version: ${{env.GO_VERSION}} | |||
| cache-key-suffix: -compile | |||
| cache-key-suffix: -core | |||
| - name: Run make dev | |||
| env: | |||
| GOBIN: ${{env.GOROOT}}/bin # windows kludge | |||
| run: | | |||
| make bootstrap | |||
There was a problem hiding this comment.
If we're caching the results of make bootstrap in mods, do we need this anymore?
There was a problem hiding this comment.
We do because GOBIN isn't part of the cache - the executables aren't cached across runners, only the GOMODCACHE and GOCACHE contents. magnetikonline/action-golang-cache#1 mentions the possibility of adding GOBIN but hasn't gotten traction. The resolution of actions/setup-go#278 might also impact what happens to the binaries.
lgfa29
approved these changes
Oct 21, 2022
| @@ -40,13 +53,14 @@ jobs: | |||
| - uses: magnetikonline/action-golang-cache@v1 | |||
| with: | |||
| go-version: ${{env.GO_VERSION}} | |||
There was a problem hiding this comment.
Not part of this work, so feel free to ignore it, but we could read the Go version from the .go-version file like the release workflow.
There was a problem hiding this comment.
yeah we should be able to set go-version-file: go.mod instead; i'm gonna try that in a follow up pr
shoenig
added
backport/1.3.x
shoenig
added a commit
that referenced
this pull request
Oct 27, 2022
* ci: use the same go mod cache for test-core jobs * ci: precache go modules * ci: add a mods precache job
shoenig
added a commit
that referenced
this pull request
Oct 27, 2022
* ci: use the same go mod cache across test-core jobs (#15006) * ci: use the same go mod cache for test-core jobs * ci: precache go modules * ci: add a mods precache job * ci: add -core suffix to mods action (#15015) Forgot to add this line to the new mods action; without it, it creates a cache different from the one used by the other jobs. * ci: use groups of tests in gha (#15018) * [no ci] use json for grouping packages for testing * [no ci] able to get packages in group * [no ci] able to run groups of tests * [no ci] more * [no ci] try disable circle unit tests * ci: use actions/checkout@v3 * ci: rename to quick * ci: need make dev in mods cache step * ci: make compile step depend on checks step * ci: bump consul and vault versions * ci: need make dev for group tests * ci: update ci unit testing docs * docs: spell plumbing correctly Co-authored-by: Tim Gross <tgross@hashicorp.com> Co-authored-by: Tim Gross <tgross@hashicorp.com> * deps: run go mod tidy Co-authored-by: Tim Gross <tgross@hashicorp.com>
shoenig
added a commit
that referenced
this pull request
Oct 27, 2022
* ci: use the same go mod cache across test-core jobs (#15006) * ci: use the same go mod cache for test-core jobs * ci: precache go modules * ci: add a mods precache job * ci: add -core suffix to mods action (#15015) Forgot to add this line to the new mods action; without it, it creates a cache different from the one used by the other jobs. * ci: use groups of tests in gha (#15018) * [no ci] use json for grouping packages for testing * [no ci] able to get packages in group * [no ci] able to run groups of tests * [no ci] more * [no ci] try disable circle unit tests * ci: use actions/checkout@v3 * ci: rename to quick * ci: need make dev in mods cache step * ci: make compile step depend on checks step * ci: bump consul and vault versions * ci: need make dev for group tests * ci: update ci unit testing docs * docs: spell plumbing correctly Co-authored-by: Tim Gross <tgross@hashicorp.com> Co-authored-by: Tim Gross <tgross@hashicorp.com> * deps: run go mod tidy Co-authored-by: Tim Gross <tgross@hashicorp.com>
shoenig
added a commit
that referenced
this pull request
Nov 3, 2022
* ci: backport of gha groups (#15058) * ci: use the same go mod cache across test-core jobs (#15006) * ci: use the same go mod cache for test-core jobs * ci: precache go modules * ci: add a mods precache job * ci: add -core suffix to mods action (#15015) Forgot to add this line to the new mods action; without it, it creates a cache different from the one used by the other jobs. * ci: use groups of tests in gha (#15018) * [no ci] use json for grouping packages for testing * [no ci] able to get packages in group * [no ci] able to run groups of tests * [no ci] more * [no ci] try disable circle unit tests * ci: use actions/checkout@v3 * ci: rename to quick * ci: need make dev in mods cache step * ci: make compile step depend on checks step * ci: bump consul and vault versions * ci: need make dev for group tests * ci: update ci unit testing docs * docs: spell plumbing correctly Co-authored-by: Tim Gross <tgross@hashicorp.com> Co-authored-by: Tim Gross <tgross@hashicorp.com> * deps: run go mod tidy Co-authored-by: Tim Gross <tgross@hashicorp.com> * build: fix makefile conflict Co-authored-by: Tim Gross <tgross@hashicorp.com>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures the
test-coreAction(?) with a newmodsjob on which theother jobs depend on. The mods job just runs
mod tidyandbootstrapto downloadall the Go modules that will be needed and caches them. The dependent jobs then make
use of the same cache so they do not need to download / cache the near 1GB of modules
themselves.
Closes #15000