Don't advertise a '::' bindAddr #198
Conversation
If no no explicit advertiseAddr is specified and we're bound to a wildcard address, we don't want to advertise the wildcard address if it's '::'. Instead of checking for 0.0.0.0 use the Go stdlib to select for all possible wild card addresses
|
|
|
@mkeeler May I gently bring this PR to your attention? :) |
There was a problem hiding this comment.
This change looks good to me. Could you add a test in net_test.go for FinalAdvertiseAddr ignoring both 0.0.0.0 and ::? I went looking for an existing test to update but apparently there are none for this function. I don't think you need to test all the existing functionality of providing a specific advertise addr or but rather just ensure that if a normal IP is specified as the bind addr it is used and if its unspecified that some other address is chosen. You wont be able to check for any specific IP as the sockaddr library is going to choose that IP based on the local system. So basically just assert that the advertised address is not 0.0.0.0 or ::
If no explicit advertiseAddr is specified and we're bound
to a wildcard address, we don't want to advertise the wildcard
address if it's '::'.
Instead of checking for 0.0.0.0 use the Go stdlib to select
for all possible wild card addresses