Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix download and verify #27

Merged
merged 6 commits into from Mar 15, 2022
Merged

Fix download and verify #27

merged 6 commits into from Mar 15, 2022

Commits on Mar 14, 2022

  1. add test case for checksum download

    @dbanck
    dbanck committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    a0f8038 View commit details
    Browse the repository at this point in the history

  2. set correct responseType for shasum downloads 

    The default axios responseType is 'json'. In this case we're downloading
a text file (list of shasums) and a binary file (the signature), so
different responeTypes are required.
    @dbanck
    dbanck committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    aa1938c View commit details
    Browse the repository at this point in the history

  3. add test for downloading and validating a release

    @dbanck
    dbanck committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    da53386 View commit details
    Browse the repository at this point in the history

  4. fix incomplete download errors 

    The download method now waits until all data has been downloaded
and written to the destination file. Before this, the method was resolved
too early, and as a result, subsequent operations ran on an incomplete
download. This caused operations like verify to fail, because of a
different shasum.
    @dbanck
    dbanck committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    ca947f4 View commit details
    Browse the repository at this point in the history

  5. add gitattributes file to fix checksum test on windows

    @dbanck
    dbanck committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    91aaf72 View commit details
    Browse the repository at this point in the history

  6. add type for shared release variable in tests

    @dbanck
    dbanck committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    99a3e2b View commit details
    Browse the repository at this point in the history