Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCE-510: update README with details about new auth and profile libraries #155

Merged
merged 7 commits into from Dec 20, 2022
Merged

HCE-510: update README with details about new auth and profile libraries #155

merged 7 commits into from Dec 20, 2022

Conversation

bcmdarroch
Copy link
Contributor

🛠️ Description

This PR updates the README:

  • rearranges the sections to put installation instructions first
  • adds a Libraries section
  • adds details about browser login

@bcmdarroch bcmdarroch requested a review from a team December 16, 2022 22:34
@bcmdarroch bcmdarroch mentioned this pull request Dec 16, 2022
Merged
insanejasper
insanejasper approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@insanejasper insanejasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This will be super helpful to users!

JolisaBrownHashiCorp
JolisaBrownHashiCorp approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@JolisaBrownHashiCorp JolisaBrownHashiCorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@bcmdarroch bcmdarroch merged commit bc97d6d into main Dec 20, 2022
@bcmdarroch bcmdarroch deleted the hce-510-lib-doc-update branch December 20, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insanejasper insanejasper insanejasper approved these changes

@JolisaBrownHashiCorp JolisaBrownHashiCorp JolisaBrownHashiCorp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcmdarroch @insanejasper @JolisaBrownHashiCorp