Insert middleware to allow org and prod id on requests #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcmdarroch
reviewed
Dec 9, 2022
httpclient/httpclient.go
Outdated
| @@ -84,6 +100,15 @@ func New(cfg Config) (runtime *httptransport.Runtime, err error) { | |||
| transport = &roundTripperWithSourceChannel{OriginalRoundTripper: transport, SourceChannel: sourceChannel} | |||
| } | |||
|
|
|||
| if cfg.Profile().OrganizationID != "" || cfg.Profile().ProjectID != "" { | |||
There was a problem hiding this comment.
Let's make sure we have validation that these are always set together. Both populated, or both empty.
bcmdarroch
reviewed
Dec 9, 2022
httpclient/httpclient.go
Outdated
| ProjectID string | ||
| } | ||
|
|
||
| func (rt *roundTripperWithProfile) RoundTrip(req *http.Request) (*http.Response, error) { |
There was a problem hiding this comment.
Would like to see a refactor where we only overwrite the Roundtrip function once. Maybe a single struct called roundTripperWithMiddleware with sourceChannel and profile middleware functions as its fields?
bcmdarroch
force-pushed
the
insert-middleware-package-hce-652
branch
from
53f7d71
to
1ad9e50
Compare
insanejasper
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
These code changes include added middleware to allow organization and project id collected from a user's profile to attach to client requests.
🔗 External Links
HCE-652 : Middleware package that injects the saved project ID/org ID into every SDK request
👍 Definition of Done