Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hclsyntax: conditional refinements of collections must use Range() #633

Merged
merged 3 commits into from
Oct 12, 2023
Merged

hclsyntax: conditional refinements of collections must use Range() #633

merged 3 commits into from
Oct 12, 2023

Commits on Oct 11, 2023

  1. refinements of collections must use Range() 

    When attempting to determine the final length range for a conditional
expression with collections, the length values may still be unknown.
Always use `Range()` to get the lower and upper bounds.
    @jbardin
    jbardin committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    3a30333 View commit details
    Browse the repository at this point in the history

  2. Range() calls must always be unmarked

    @jbardin
    jbardin committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e4589e3 View commit details
    Browse the repository at this point in the history

  3. further refine refinement handling 

    Correct mark handling for some conditional values.

Find correct refinement for overlapping ranges which could not have been
compared with `GreaterThan`. Also map inclusive flags for numeric
ranges.

Correct handling of DefinitelyNotNull collections.

Return a known null early when both conditional branches are null.
    @jbardin
    jbardin committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    bad33d5 View commit details
    Browse the repository at this point in the history