Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetAttribute* methods are not returning new Attribute #613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jfremy
Copy link

@jfremy jfremy commented May 28, 2023

The SetAttribute* methods are supposed to return the considered attribute (new or existing) However, because of the variable shadowing in the creation path, it does not return the new Attribute and instead return nil

Fix the code to return the create Attribute when it is not already present in the body

The SetAttribute* methods are supposed to return the considered attribute (new or existing)
However, because of the variable shadowing in the creation path,  it does not return the new Attribute and instead return nil

Fix the code to return the create Attribute when it is not already present in the body
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants