Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext/typeexpr: Convert defaults for optional attrs #555

Merged
merged 1 commit into from Sep 23, 2022

Commits on Sep 22, 2022

  1. ext/typeexpr: Convert defaults for optional attrs

    When parsing optional object attribute defaults, we previously verified
    that the default value was convertible to the attribute type. However,
    we did not keep this converted value.
    
    This commit uses the converted default value, rather than delaying
    conversion until later. In turn this prevents crashes when transforming
    collections which contain objects with optional attributes, caused by
    incompatible object types at the time of defaults application.
    alisdair committed Sep 22, 2022
    Copy the full SHA
    b857322 View commit details
    Browse the repository at this point in the history