Add support for dynamic blocks when using ',remain' tag #469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
We wanted a
map[string]cty.Value
from HCL. We tried using amap
incty
but that means all the values should be of the same type, e.g. this fails:So we resorted to using a block
fields { ... }
with the,remain
tag and the following go struct:And now we can do:
However this fails inside the
dynamic
block because thebody.JustAttributes()
method does not respect the scope/iteration inside adynamic
block. This small PR addresses this and would be great if you accept this PR.