github: Create CODEOWNERS #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could potentially add: ... as it looks like that's the only bit the Nomad team contributed to. |
radeksimko
approved these changes
May 14, 2024
There was a problem hiding this comment.
Can/should there be anyone else on this list or is it really just the Core team?
Right now it's mostly myself and @kmoe so I think the proposed owner group represents the reality. The DevEx team is also a heavy user AFAIK in the testing library of providers but I'm not sure how much do they want to be involved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized this repo was also missing a CODEOWNERS. Can/should there be anyone else on this list or is it really just the Core team? I see a couple of commits from bflad and from a couple of Nomad team engineers, but that's it.