Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releasesjson: Fix missing Version in unmarshaled response #192

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Apr 4, 2024

I cannot think of a good reason why we had the RawVersion field there. It may have pre-dated go-version's ability to unmarshal. Either way, this has led to a weird error message, as discovered by @bschaatsbergen in #191

 $ ./hc-install install -version 1.0.0 terraform
hc-install: will install terraform@1.0.0
failed to install terraform@1.0.0: no ZIP archive found for terraform <nil> darwin/arm64

After patch

$ go run ./cmd/hc-install install -version 1.0.0 terraform
hc-install: will install terraform@1.0.0
failed to install terraform@1.0.0: no ZIP archive found for terraform 1.0.0 darwin/arm64
exit status 1

@radeksimko radeksimko marked this pull request as ready for review April 4, 2024 09:56
Copy link
Member

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@radeksimko radeksimko added the bug Something isn't working label Apr 4, 2024
@radeksimko radeksimko merged commit 6d13f0e into main Apr 4, 2024
11 checks passed
@radeksimko radeksimko deleted the b-fix-unmarshalling-error branch April 4, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants