Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New interface #12

Merged
merged 3 commits into from
Jul 6, 2021
Merged

New interface #12

merged 3 commits into from
Jul 6, 2021

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jun 25, 2021 •
edited

@radeksimko radeksimko force-pushed the f-new-interface branch 2 times, most recently from 6f9324a to 4ffa923 Compare June 25, 2021 17:46
@radeksimko radeksimko force-pushed the f-new-interface branch 7 times, most recently from 17db9db to 7568a27 Compare June 29, 2021 19:14
@radeksimko radeksimko requested a review from kmoe June 29, 2021 19:18
@radeksimko radeksimko marked this pull request as ready for review June 29, 2021 19:18
kmoe
kmoe approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@kmoe kmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, I like this direction and I'll update the RFC as the next step so we can get more eyes on this API. This is a great prototype.

Happy to merge this now if the README is updated, and convert the remaining TODOs into issues.

@radeksimko radeksimko force-pushed the f-new-interface branch 5 times, most recently from 58dc4c6 to d32397f Compare July 5, 2021 21:14
@radeksimko radeksimko changed the title WIP: New interface New interface Jul 6, 2021
@radeksimko radeksimko merged commit d9e6189 into main Jul 6, 2021
@radeksimko radeksimko deleted the f-new-interface branch July 6, 2021 10:02
This was referenced Jul 6, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmoe kmoe kmoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@radeksimko @kmoe