renamed GetOrAdd to GetOrAddFunc, return error if constructor fails

hashicorp · Jan 19, 2024 · d25bb3b · d25bb3b
1 parent 48bb232
commit d25bb3b
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/expirable/expirable_lru_test.go b/expirable/expirable_lru_test.go
@@ -336,15 +336,15 @@ func TestLRUConcurrency(t *testing.T) {
 	}
 }
 
-func TestLRUGetOrAddConcurrency(t *testing.T) {
+func TestLRUGetOrAddFuncConcurrency(t *testing.T) {
 	lc := NewLRU[string, string](0, nil, 0)
 	wg := sync.WaitGroup{}
 	wg.Add(1000)
 	var evictedCount int32
 	var addedCount int32
 	for i := 0; i < 1000; i++ {
 		go func(i int) {
-			_, added, evicted := lc.GetOrAdd(fmt.Sprintf("key-%d", i/10), func() string { return fmt.Sprintf("val-%d", i/10) })
+			_, added, evicted, _ := lc.GetOrAddFunc(fmt.Sprintf("key-%d", i/10), func() (string, error) { return fmt.Sprintf("val-%d", i/10), nil })
 			if evicted {
 				atomic.AddInt32(&evictedCount, 1)
 			}
@@ -359,10 +359,10 @@ func TestLRUGetOrAddConcurrency(t *testing.T) {
 		t.Fatalf("length differs from expected")
 	}
 	if addedCount != 100 {
-		t.Fatalf("GetOrAdd: unexpected added count %d", addedCount)
+		t.Fatalf("GetOrAddFunc: unexpected added count %d", addedCount)
 	}
 	if evictedCount > 0 {
-		t.Fatalf("GetOrAdd: unexpected evicted count %d", evictedCount)
+		t.Fatalf("GetOrAddFunc: unexpected evicted count %d", evictedCount)
 	}
 }