Add Manage Permissions to Team Organization Access #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliannatetreault
force-pushed
the
juliannatetreault/TF-14028-add-manage-permissions
branch
from
68d2220
to
d62efb0
Compare
Open
2 tasks
juliannatetreault
force-pushed
the
juliannatetreault/TF-14028-add-manage-permissions
branch
from
d62efb0
to
05f4417
Compare
juliannatetreault
force-pushed
the
juliannatetreault/TF-14028-add-manage-permissions
branch
from
05f4417
to
c9ca2fb
Compare
JarrettSpiker
requested changes
Apr 24, 2024
juliannatetreault
force-pushed
the
juliannatetreault/TF-14028-add-manage-permissions
branch
from
c9ca2fb
to
f6f97eb
Compare
juliannatetreault
force-pushed
the
juliannatetreault/TF-14028-add-manage-permissions
branch
2 times, most recently
from
cca8222
to
a0d8703
Compare
juliannatetreault
force-pushed
the
juliannatetreault/TF-14028-add-manage-permissions
branch
from
667a46e
to
86d24e4
Compare
JarrettSpiker
approved these changes
May 1, 2024
juliannatetreault
deleted the
juliannatetreault/TF-14028-add-manage-permissions
branch
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds new manage permissions -
ManageTeams,ManageOrganizationAccess, andAccessSecretTeams- to team organization access. Additionally, this PR adds tests for the new permissions.Testing plan
ManageTeams,ManageOrganizationAccess, andAccessSecretTeamsarefalseby default when Teams are created.ManageTeams,ManageOrganizationAccess, andAccessSecretTeamsis read for Teams.ManageTeams,ManageOrganizationAccess, andAccessSecretTeamsshould be updatable through theOrganizationAccessOptions.External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.