Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused agent-pool-id field from Workspace model #815

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

brandonc
Copy link
Collaborator

This is not a response attribute in the API and should never be populated or used.

@brandonc brandonc requested a review from a team as a code owner November 10, 2023 20:46
laurenolivia
laurenolivia previously approved these changes Nov 10, 2023
nfagerlund
nfagerlund previously approved these changes Nov 10, 2023
Copy link
Contributor

@nfagerlund nfagerlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh what?? Hilarious! That's from 2020, wonder if we just missed it or if the API changed.

@brandonc
Copy link
Collaborator Author

@nfagerlund @laurenolivia I pushed a CHANGELOG commit and that dismissed your approvals.

@brandonc brandonc merged commit a17cfb1 into main Nov 13, 2023
10 checks passed
@brandonc brandonc deleted the brandonc/remove_unused_agent-pool-id_field branch November 13, 2023 16:55
@brandonc brandonc restored the brandonc/remove_unused_agent-pool-id_field branch November 13, 2023 16:55
@brandonc brandonc deleted the brandonc/remove_unused_agent-pool-id_field branch November 13, 2023 16:55
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants