Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.39.1 Changelog, upgrade go-retryablehttp to v0.7.5 #813

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

sebasslash
Copy link
Contributor

Title

@sebasslash sebasslash requested a review from a team as a code owner November 8, 2023 22:03
CHANGELOG.md Outdated Show resolved Hide resolved
@sebasslash sebasslash force-pushed the sebasslash/upgrade-go-retryablehttp branch from 935cdae to ebc055a Compare November 8, 2023 22:15
Copy link
Contributor

@nfagerlund nfagerlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth doing a link to the pull request in the changelog, even though it doesn't contain code that fixes the problem! It'll help anyone in the future trying to track down where the fix came from. :)

@sebasslash sebasslash force-pushed the sebasslash/upgrade-go-retryablehttp branch from ebc055a to 2ada65d Compare November 8, 2023 22:28
Copy link
Contributor

@nfagerlund nfagerlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼!

@sebasslash sebasslash merged commit 09f6c3a into main Nov 8, 2023
10 checks passed
@sebasslash sebasslash deleted the sebasslash/upgrade-go-retryablehttp branch November 8, 2023 23:31
Copy link

github-actions bot commented Nov 8, 2023

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants