Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF-9605] Add validation when configuring Registry Module Publishing #804

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

hashimoon
Copy link
Contributor

@hashimoon hashimoon commented Nov 2, 2023

Description

This change throws the exception when setting tags to true and a branch is present when configuring the VCSRepo for a RegistryModule. Currently, if a branch is provided in the API request, the backend will give precedence to the branch value and return the value for tags as false, which can lead to user confusion.

Testing plan

  1. Create a RegistryModule with a VCS connection
  2. Set VCSRepo tags to true
  3. Set VCSRepo branch to main
  4. Verify that an exception is thrown

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" go test ./... -v -run TestRegistryModule
?   	github.com/hashicorp/go-tfe/examples/backing_data	[no test files]
?   	github.com/hashicorp/go-tfe/examples/configuration_versions	[no test files]
?   	github.com/hashicorp/go-tfe/examples/organizations	[no test files]
?   	github.com/hashicorp/go-tfe/examples/registry_modules	[no test files]
?   	github.com/hashicorp/go-tfe/examples/run_errors	[no test files]
?   	github.com/hashicorp/go-tfe/examples/state_versions	[no test files]
?   	github.com/hashicorp/go-tfe/examples/users	[no test files]
?   	github.com/hashicorp/go-tfe/examples/workspaces	[no test files]
?   	github.com/hashicorp/go-tfe/mocks	[no test files]
=== RUN   TestRegistryModulesList
=== RUN   TestRegistryModulesList/with_no_list_options
=== RUN   TestRegistryModulesList/with_list_options
--- PASS: TestRegistryModulesList (2.36s)
    --- PASS: TestRegistryModulesList/with_no_list_options (0.19s)
    --- PASS: TestRegistryModulesList/with_list_options (0.44s)
=== RUN   TestRegistryModulesCreate
=== RUN   TestRegistryModulesCreate/with_valid_options
=== RUN   TestRegistryModulesCreate/with_valid_options/without_RegistryName
=== RUN   TestRegistryModulesCreate/with_valid_options/without_RegistryName/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/without_RegistryName/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/without_RegistryName/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_private_RegistryName
=== RUN   TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_public_RegistryName
=== RUN   TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_no-code_attribute
2023/11/06 12:11:52 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to create a no-code module is with the registryNoCodeModules.Create method.
=== RUN   TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_invalid_options
=== RUN   TestRegistryModulesCreate/with_invalid_options/without_a_name
=== RUN   TestRegistryModulesCreate/with_invalid_options/with_an_invalid_name
=== RUN   TestRegistryModulesCreate/with_invalid_options/without_a_provider
=== RUN   TestRegistryModulesCreate/with_invalid_options/with_an_invalid_provider
=== RUN   TestRegistryModulesCreate/with_invalid_options/with_an_invalid_registry_name
=== RUN   TestRegistryModulesCreate/with_invalid_options/without_a_namespace_for_public_registry_name
=== RUN   TestRegistryModulesCreate/with_invalid_options/with_a_namespace_for_private_registry_name
=== RUN   TestRegistryModulesCreate/without_a_valid_organization
--- PASS: TestRegistryModulesCreate (2.39s)
    --- PASS: TestRegistryModulesCreate/with_valid_options (0.81s)
        --- PASS: TestRegistryModulesCreate/with_valid_options/without_RegistryName (0.20s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/without_RegistryName/permissions_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/without_RegistryName/relationships_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/without_RegistryName/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreate/with_valid_options/with_private_RegistryName (0.18s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/permissions_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/relationships_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreate/with_valid_options/with_public_RegistryName (0.19s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/permissions_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/relationships_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreate/with_valid_options/with_no-code_attribute (0.25s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/permissions_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/relationships_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/timestamps_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesCreate/with_invalid_options (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/without_a_name (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/with_an_invalid_name (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/without_a_provider (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/with_an_invalid_provider (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/with_an_invalid_registry_name (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/without_a_namespace_for_public_registry_name (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/with_a_namespace_for_private_registry_name (0.00s)
    --- PASS: TestRegistryModulesCreate/without_a_valid_organization (0.00s)
=== RUN   TestRegistryModuleUpdate
=== RUN   TestRegistryModuleUpdate/enable_no-code
2023/11/06 12:11:54 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to update a no-code module is with the registryNoCodeModules.Update method.
=== RUN   TestRegistryModuleUpdate/disable_no-code
2023/11/06 12:11:54 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to update a no-code module is with the registryNoCodeModules.Update method.
--- PASS: TestRegistryModuleUpdate (3.25s)
    --- PASS: TestRegistryModuleUpdate/enable_no-code (0.40s)
    --- PASS: TestRegistryModuleUpdate/disable_no-code (1.00s)
=== RUN   TestRegistryModuleUpdateWithVCSConnection
=== RUN   TestRegistryModuleUpdateWithVCSConnection/enable_no-code
2023/11/06 12:11:58 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to update a no-code module is with the registryNoCodeModules.Update method.
=== RUN   TestRegistryModuleUpdateWithVCSConnection/disable_no-code
2023/11/06 12:11:59 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to update a no-code module is with the registryNoCodeModules.Update method.
=== RUN   TestRegistryModuleUpdateWithVCSConnection/prevents_setting_the_branch_when_using_tag_based_publishing
=== RUN   TestRegistryModuleUpdateWithVCSConnection/toggle_between_git_tag-based_and_branch-based_publishing
--- PASS: TestRegistryModuleUpdateWithVCSConnection (7.23s)
    --- PASS: TestRegistryModuleUpdateWithVCSConnection/enable_no-code (0.31s)
    --- PASS: TestRegistryModuleUpdateWithVCSConnection/disable_no-code (0.20s)
    --- PASS: TestRegistryModuleUpdateWithVCSConnection/prevents_setting_the_branch_when_using_tag_based_publishing (0.23s)
    --- PASS: TestRegistryModuleUpdateWithVCSConnection/toggle_between_git_tag-based_and_branch-based_publishing (0.69s)
=== RUN   TestRegistryModulesCreateVersion
=== RUN   TestRegistryModulesCreateVersion/with_valid_options
=== RUN   TestRegistryModulesCreateVersion/with_valid_options/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreateVersion/with_valid_options/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreateVersion/with_valid_options/links_are_properly_decoded
=== RUN   TestRegistryModulesCreateVersion/with_prerelease_and_metadata_version
=== RUN   TestRegistryModulesCreateVersion/with_invalid_options
=== RUN   TestRegistryModulesCreateVersion/with_invalid_options/without_version
=== RUN   TestRegistryModulesCreateVersion/with_invalid_options/with_invalid_version
=== RUN   TestRegistryModulesCreateVersion/without_a_name
=== RUN   TestRegistryModulesCreateVersion/with_an_invalid_name
=== RUN   TestRegistryModulesCreateVersion/without_a_provider
=== RUN   TestRegistryModulesCreateVersion/with_an_invalid_provider
=== RUN   TestRegistryModulesCreateVersion/without_a_valid_organization
--- PASS: TestRegistryModulesCreateVersion (2.34s)
    --- PASS: TestRegistryModulesCreateVersion/with_valid_options (0.23s)
        --- PASS: TestRegistryModulesCreateVersion/with_valid_options/relationships_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreateVersion/with_valid_options/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreateVersion/with_valid_options/links_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/with_prerelease_and_metadata_version (0.32s)
    --- PASS: TestRegistryModulesCreateVersion/with_invalid_options (0.00s)
        --- PASS: TestRegistryModulesCreateVersion/with_invalid_options/without_version (0.00s)
        --- PASS: TestRegistryModulesCreateVersion/with_invalid_options/with_invalid_version (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/without_a_name (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/with_an_invalid_name (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/without_a_provider (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/with_an_invalid_provider (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/without_a_valid_organization (0.00s)
=== RUN   TestRegistryModulesShowVersion
=== RUN   TestRegistryModulesShowVersion/when_the_version_exists
=== RUN   TestRegistryModulesShowVersion/when_the_version_exists/relationships_are_properly_decoded
=== RUN   TestRegistryModulesShowVersion/when_the_version_exists/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesShowVersion/when_the_version_exists/links_are_properly_decoded
=== RUN   TestRegistryModulesShowVersion/when_reading_a_version_that_does_not_exist
--- PASS: TestRegistryModulesShowVersion (2.73s)
    --- PASS: TestRegistryModulesShowVersion/when_the_version_exists (0.38s)
        --- PASS: TestRegistryModulesShowVersion/when_the_version_exists/relationships_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesShowVersion/when_the_version_exists/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesShowVersion/when_the_version_exists/links_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesShowVersion/when_reading_a_version_that_does_not_exist (0.39s)
=== RUN   TestRegistryModulesListCommit
=== RUN   TestRegistryModulesListCommit/with_valid_options
=== RUN   TestRegistryModulesListCommit/with_valid_options/permissions_are_properly_decoded
=== RUN   TestRegistryModulesListCommit/with_valid_options/listing_commits
=== RUN   TestRegistryModulesListCommit/when_a_VCS_connection_is_not_present
=== RUN   TestRegistryModulesListCommit/when_a_VCS_connection_is_not_present/listing_commits
--- PASS: TestRegistryModulesListCommit (7.46s)
    --- PASS: TestRegistryModulesListCommit/with_valid_options (3.01s)
        --- PASS: TestRegistryModulesListCommit/with_valid_options/permissions_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesListCommit/with_valid_options/listing_commits (1.63s)
    --- PASS: TestRegistryModulesListCommit/when_a_VCS_connection_is_not_present (0.65s)
        --- PASS: TestRegistryModulesListCommit/when_a_VCS_connection_is_not_present/listing_commits (0.17s)
=== RUN   TestRegistryModulesCreateWithVCSConnection
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_valid_options
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_valid_options/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_valid_options/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_valid_options/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_an_identifier
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_an_oauth_token_ID
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_a_display_identifier
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options/when_tags_are_enabled_and_a_branch_is_provided
=== RUN   TestRegistryModulesCreateWithVCSConnection/without_options
--- PASS: TestRegistryModulesCreateWithVCSConnection (7.24s)
    --- PASS: TestRegistryModulesCreateWithVCSConnection/with_valid_options (1.31s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_valid_options/permissions_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_valid_options/relationships_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_valid_options/timestamps_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_an_identifier (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_an_oauth_token_ID (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_a_display_identifier (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options/when_tags_are_enabled_and_a_branch_is_provided (0.00s)
    --- PASS: TestRegistryModulesCreateWithVCSConnection/without_options (0.00s)
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnection
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnection/with_valid_options
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnection/with_invalid_options
--- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnection (5.22s)
    --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnection/with_valid_options (1.34s)
    --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnection/with_invalid_options (0.00s)
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_valid_options
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_valid_options/tests_are_enabled
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_invalid_options
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_invalid_options/when_the_the_module_is_not_branch_based_and_test_are_enabled
--- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting (5.21s)
    --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_valid_options (1.34s)
        --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_valid_options/tests_are_enabled (0.00s)
    --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_invalid_options (0.00s)
        --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_invalid_options/when_the_the_module_is_not_branch_based_and_test_are_enabled (0.00s)
=== RUN   TestRegistryModulesCreateWithGithubApp
    registry_module_integration_test.go:1025: Export a valid GITHUB_APP_INSTALLATION_ID before running this test!
--- SKIP: TestRegistryModulesCreateWithGithubApp (0.00s)
=== RUN   TestRegistryModulesRead
=== RUN   TestRegistryModulesRead/with_valid_name_and_provider
2023/11/06 12:12:35 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:12:35 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
=== RUN   TestRegistryModulesRead/with_valid_name_and_provider/permissions_are_properly_decoded
=== RUN   TestRegistryModulesRead/with_valid_name_and_provider/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_private_module
=== RUN   TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_private_module/permissions_are_properly_decoded
=== RUN   TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_private_module/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_public_module
=== RUN   TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_public_module/permissions_are_properly_decoded
=== RUN   TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_public_module/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesRead/without_a_name
=== RUN   TestRegistryModulesRead/with_an_invalid_name
=== RUN   TestRegistryModulesRead/without_a_provider
=== RUN   TestRegistryModulesRead/with_an_invalid_provider
=== RUN   TestRegistryModulesRead/with_an_invalid_registry_name
=== RUN   TestRegistryModulesRead/without_a_valid_organization
=== RUN   TestRegistryModulesRead/without_a_valid_namespace_for_public_registry_module
=== RUN   TestRegistryModulesRead/when_the_registry_module_does_not_exist
2023/11/06 12:12:35 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:12:35 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
--- PASS: TestRegistryModulesRead (3.08s)
    --- PASS: TestRegistryModulesRead/with_valid_name_and_provider (0.24s)
        --- PASS: TestRegistryModulesRead/with_valid_name_and_provider/permissions_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesRead/with_valid_name_and_provider/timestamps_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_private_module (0.16s)
        --- PASS: TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_private_module/permissions_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_private_module/timestamps_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_public_module (0.17s)
        --- PASS: TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_public_module/permissions_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_public_module/timestamps_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesRead/without_a_name (0.00s)
    --- PASS: TestRegistryModulesRead/with_an_invalid_name (0.00s)
    --- PASS: TestRegistryModulesRead/without_a_provider (0.00s)
    --- PASS: TestRegistryModulesRead/with_an_invalid_provider (0.00s)
    --- PASS: TestRegistryModulesRead/with_an_invalid_registry_name (0.00s)
    --- PASS: TestRegistryModulesRead/without_a_valid_organization (0.00s)
    --- PASS: TestRegistryModulesRead/without_a_valid_namespace_for_public_registry_module (0.00s)
    --- PASS: TestRegistryModulesRead/when_the_registry_module_does_not_exist (0.18s)
=== RUN   TestRegistryModulesDelete
=== RUN   TestRegistryModulesDelete/with_valid_name
2023/11/06 12:12:38 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:12:38 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
=== RUN   TestRegistryModulesDelete/without_a_name
=== RUN   TestRegistryModulesDelete/with_an_invalid_name
=== RUN   TestRegistryModulesDelete/without_a_valid_organization
=== RUN   TestRegistryModulesDelete/when_the_registry_module_does_not_exist
--- PASS: TestRegistryModulesDelete (2.14s)
    --- PASS: TestRegistryModulesDelete/with_valid_name (0.35s)
    --- PASS: TestRegistryModulesDelete/without_a_name (0.00s)
    --- PASS: TestRegistryModulesDelete/with_an_invalid_name (0.00s)
    --- PASS: TestRegistryModulesDelete/without_a_valid_organization (0.00s)
    --- PASS: TestRegistryModulesDelete/when_the_registry_module_does_not_exist (0.14s)
=== RUN   TestRegistryModulesDeleteProvider
=== RUN   TestRegistryModulesDeleteProvider/with_valid_name_and_provider
2023/11/06 12:12:40 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:12:40 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
=== RUN   TestRegistryModulesDeleteProvider/without_a_name
=== RUN   TestRegistryModulesDeleteProvider/with_an_invalid_name
=== RUN   TestRegistryModulesDeleteProvider/without_a_provider
=== RUN   TestRegistryModulesDeleteProvider/with_an_invalid_provider
=== RUN   TestRegistryModulesDeleteProvider/without_a_valid_organization
=== RUN   TestRegistryModulesDeleteProvider/when_the_registry_module_name_and_provider_do_not_exist
--- PASS: TestRegistryModulesDeleteProvider (2.00s)
    --- PASS: TestRegistryModulesDeleteProvider/with_valid_name_and_provider (0.32s)
    --- PASS: TestRegistryModulesDeleteProvider/without_a_name (0.00s)
    --- PASS: TestRegistryModulesDeleteProvider/with_an_invalid_name (0.00s)
    --- PASS: TestRegistryModulesDeleteProvider/without_a_provider (0.00s)
    --- PASS: TestRegistryModulesDeleteProvider/with_an_invalid_provider (0.00s)
    --- PASS: TestRegistryModulesDeleteProvider/without_a_valid_organization (0.00s)
    --- PASS: TestRegistryModulesDeleteProvider/when_the_registry_module_name_and_provider_do_not_exist (0.14s)
=== RUN   TestRegistryModulesDeleteVersion
2023/11/06 12:12:43 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:12:43 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
=== RUN   TestRegistryModulesDeleteVersion/with_valid_name_and_provider
2023/11/06 12:12:44 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:12:44 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
2023/11/06 12:12:44 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:12:44 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
=== RUN   TestRegistryModulesDeleteVersion/with_prerelease_and_metadata_version
2023/11/06 12:12:45 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:12:45 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
2023/11/06 12:12:45 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:12:45 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
=== RUN   TestRegistryModulesDeleteVersion/without_a_name
=== RUN   TestRegistryModulesDeleteVersion/with_an_invalid_name
=== RUN   TestRegistryModulesDeleteVersion/without_a_provider
=== RUN   TestRegistryModulesDeleteVersion/with_an_invalid_provider
=== RUN   TestRegistryModulesDeleteVersion/without_a_version
=== RUN   TestRegistryModulesDeleteVersion/with_an_invalid_version
=== RUN   TestRegistryModulesDeleteVersion/without_a_valid_organization
=== RUN   TestRegistryModulesDeleteVersion/when_the_registry_module_name,_provider,_and_version_do_not_exist
--- PASS: TestRegistryModulesDeleteVersion (5.70s)
    --- PASS: TestRegistryModulesDeleteVersion/with_valid_name_and_provider (0.93s)
    --- PASS: TestRegistryModulesDeleteVersion/with_prerelease_and_metadata_version (0.79s)
    --- PASS: TestRegistryModulesDeleteVersion/without_a_name (0.00s)
    --- PASS: TestRegistryModulesDeleteVersion/with_an_invalid_name (0.00s)
    --- PASS: TestRegistryModulesDeleteVersion/without_a_provider (0.00s)
    --- PASS: TestRegistryModulesDeleteVersion/with_an_invalid_provider (0.00s)
    --- PASS: TestRegistryModulesDeleteVersion/without_a_version (0.00s)
    --- PASS: TestRegistryModulesDeleteVersion/with_an_invalid_version (0.00s)
    --- PASS: TestRegistryModulesDeleteVersion/without_a_valid_organization (0.00s)
    --- PASS: TestRegistryModulesDeleteVersion/when_the_registry_module_name,_provider,_and_version_do_not_exist (0.13s)
=== RUN   TestRegistryModulesUpload
=== RUN   TestRegistryModulesUpload/with_valid_upload_URL
=== RUN   TestRegistryModulesUpload/with_missing_upload_URL
--- PASS: TestRegistryModulesUpload (1.98s)
    --- PASS: TestRegistryModulesUpload/with_valid_upload_URL (0.04s)
    --- PASS: TestRegistryModulesUpload/with_missing_upload_URL (0.00s)
=== RUN   TestRegistryModulesUploadTarGzip
=== RUN   TestRegistryModulesUploadTarGzip/with_custom_go-slug
=== RUN   TestRegistryModulesUploadTarGzip/with_custom_tar_archive
--- PASS: TestRegistryModulesUploadTarGzip (3.14s)
    --- PASS: TestRegistryModulesUploadTarGzip/with_custom_go-slug (0.03s)
    --- PASS: TestRegistryModulesUploadTarGzip/with_custom_tar_archive (0.04s)
=== RUN   TestRegistryModule_Unmarshal
--- PASS: TestRegistryModule_Unmarshal (0.00s)
=== RUN   TestRegistryModulesList
=== RUN   TestRegistryModulesList/with_no_list_options
=== RUN   TestRegistryModulesList/with_list_options
--- PASS: TestRegistryModulesList (4.73s)
    --- PASS: TestRegistryModulesList/with_no_list_options (0.26s)
    --- PASS: TestRegistryModulesList/with_list_options (2.28s)
=== RUN   TestRegistryModulesCreate
=== RUN   TestRegistryModulesCreate/with_valid_options
=== RUN   TestRegistryModulesCreate/with_valid_options/without_RegistryName
=== RUN   TestRegistryModulesCreate/with_valid_options/without_RegistryName/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/without_RegistryName/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/without_RegistryName/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_private_RegistryName
=== RUN   TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_public_RegistryName
=== RUN   TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_no-code_attribute
2023/11/06 12:12:58 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to create a no-code module is with the registryNoCodeModules.Create method.
=== RUN   TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreate/with_invalid_options
=== RUN   TestRegistryModulesCreate/with_invalid_options/without_a_name
=== RUN   TestRegistryModulesCreate/with_invalid_options/with_an_invalid_name
=== RUN   TestRegistryModulesCreate/with_invalid_options/without_a_provider
=== RUN   TestRegistryModulesCreate/with_invalid_options/with_an_invalid_provider
=== RUN   TestRegistryModulesCreate/with_invalid_options/with_an_invalid_registry_name
=== RUN   TestRegistryModulesCreate/with_invalid_options/without_a_namespace_for_public_registry_name
=== RUN   TestRegistryModulesCreate/with_invalid_options/with_a_namespace_for_private_registry_name
=== RUN   TestRegistryModulesCreate/without_a_valid_organization
--- PASS: TestRegistryModulesCreate (2.35s)
    --- PASS: TestRegistryModulesCreate/with_valid_options (0.88s)
        --- PASS: TestRegistryModulesCreate/with_valid_options/without_RegistryName (0.21s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/without_RegistryName/permissions_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/without_RegistryName/relationships_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/without_RegistryName/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreate/with_valid_options/with_private_RegistryName (0.19s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/permissions_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/relationships_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_private_RegistryName/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreate/with_valid_options/with_public_RegistryName (0.29s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/permissions_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/relationships_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_public_RegistryName/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreate/with_valid_options/with_no-code_attribute (0.20s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/permissions_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/relationships_are_properly_decoded (0.00s)
            --- PASS: TestRegistryModulesCreate/with_valid_options/with_no-code_attribute/timestamps_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesCreate/with_invalid_options (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/without_a_name (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/with_an_invalid_name (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/without_a_provider (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/with_an_invalid_provider (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/with_an_invalid_registry_name (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/without_a_namespace_for_public_registry_name (0.00s)
        --- PASS: TestRegistryModulesCreate/with_invalid_options/with_a_namespace_for_private_registry_name (0.00s)
    --- PASS: TestRegistryModulesCreate/without_a_valid_organization (0.00s)
=== RUN   TestRegistryModuleUpdate
=== RUN   TestRegistryModuleUpdate/enable_no-code
2023/11/06 12:13:00 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to update a no-code module is with the registryNoCodeModules.Update method.
=== RUN   TestRegistryModuleUpdate/disable_no-code
2023/11/06 12:13:00 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to update a no-code module is with the registryNoCodeModules.Update method.
--- PASS: TestRegistryModuleUpdate (2.62s)
    --- PASS: TestRegistryModuleUpdate/enable_no-code (0.39s)
    --- PASS: TestRegistryModuleUpdate/disable_no-code (0.37s)
=== RUN   TestRegistryModuleUpdateWithVCSConnection
=== RUN   TestRegistryModuleUpdateWithVCSConnection/enable_no-code
2023/11/06 12:13:04 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to update a no-code module is with the registryNoCodeModules.Update method.
=== RUN   TestRegistryModuleUpdateWithVCSConnection/disable_no-code
2023/11/06 12:13:04 [WARN] Support for using the NoCode field is deprecated as of release 1.22.0 and may be removed in a future version. The preferred way to update a no-code module is with the registryNoCodeModules.Update method.
=== RUN   TestRegistryModuleUpdateWithVCSConnection/prevents_setting_the_branch_when_using_tag_based_publishing
=== RUN   TestRegistryModuleUpdateWithVCSConnection/toggle_between_git_tag-based_and_branch-based_publishing
--- PASS: TestRegistryModuleUpdateWithVCSConnection (6.69s)
    --- PASS: TestRegistryModuleUpdateWithVCSConnection/enable_no-code (0.30s)
    --- PASS: TestRegistryModuleUpdateWithVCSConnection/disable_no-code (0.19s)
    --- PASS: TestRegistryModuleUpdateWithVCSConnection/prevents_setting_the_branch_when_using_tag_based_publishing (0.21s)
    --- PASS: TestRegistryModuleUpdateWithVCSConnection/toggle_between_git_tag-based_and_branch-based_publishing (0.78s)
=== RUN   TestRegistryModulesCreateVersion
=== RUN   TestRegistryModulesCreateVersion/with_valid_options
=== RUN   TestRegistryModulesCreateVersion/with_valid_options/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreateVersion/with_valid_options/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreateVersion/with_valid_options/links_are_properly_decoded
=== RUN   TestRegistryModulesCreateVersion/with_prerelease_and_metadata_version
=== RUN   TestRegistryModulesCreateVersion/with_invalid_options
=== RUN   TestRegistryModulesCreateVersion/with_invalid_options/without_version
=== RUN   TestRegistryModulesCreateVersion/with_invalid_options/with_invalid_version
=== RUN   TestRegistryModulesCreateVersion/without_a_name
=== RUN   TestRegistryModulesCreateVersion/with_an_invalid_name
=== RUN   TestRegistryModulesCreateVersion/without_a_provider
=== RUN   TestRegistryModulesCreateVersion/with_an_invalid_provider
=== RUN   TestRegistryModulesCreateVersion/without_a_valid_organization
--- PASS: TestRegistryModulesCreateVersion (2.29s)
    --- PASS: TestRegistryModulesCreateVersion/with_valid_options (0.21s)
        --- PASS: TestRegistryModulesCreateVersion/with_valid_options/relationships_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreateVersion/with_valid_options/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreateVersion/with_valid_options/links_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/with_prerelease_and_metadata_version (0.19s)
    --- PASS: TestRegistryModulesCreateVersion/with_invalid_options (0.00s)
        --- PASS: TestRegistryModulesCreateVersion/with_invalid_options/without_version (0.00s)
        --- PASS: TestRegistryModulesCreateVersion/with_invalid_options/with_invalid_version (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/without_a_name (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/with_an_invalid_name (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/without_a_provider (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/with_an_invalid_provider (0.00s)
    --- PASS: TestRegistryModulesCreateVersion/without_a_valid_organization (0.00s)
=== RUN   TestRegistryModulesShowVersion
=== RUN   TestRegistryModulesShowVersion/when_the_version_exists
=== RUN   TestRegistryModulesShowVersion/when_the_version_exists/relationships_are_properly_decoded
=== RUN   TestRegistryModulesShowVersion/when_the_version_exists/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesShowVersion/when_the_version_exists/links_are_properly_decoded
=== RUN   TestRegistryModulesShowVersion/when_reading_a_version_that_does_not_exist
--- PASS: TestRegistryModulesShowVersion (2.58s)
    --- PASS: TestRegistryModulesShowVersion/when_the_version_exists (0.35s)
        --- PASS: TestRegistryModulesShowVersion/when_the_version_exists/relationships_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesShowVersion/when_the_version_exists/timestamps_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesShowVersion/when_the_version_exists/links_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesShowVersion/when_reading_a_version_that_does_not_exist (0.42s)
=== RUN   TestRegistryModulesListCommit
=== RUN   TestRegistryModulesListCommit/with_valid_options
=== RUN   TestRegistryModulesListCommit/with_valid_options/permissions_are_properly_decoded
=== RUN   TestRegistryModulesListCommit/with_valid_options/listing_commits
=== RUN   TestRegistryModulesListCommit/when_a_VCS_connection_is_not_present
=== RUN   TestRegistryModulesListCommit/when_a_VCS_connection_is_not_present/listing_commits
--- PASS: TestRegistryModulesListCommit (6.25s)
    --- PASS: TestRegistryModulesListCommit/with_valid_options (1.97s)
        --- PASS: TestRegistryModulesListCommit/with_valid_options/permissions_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesListCommit/with_valid_options/listing_commits (0.62s)
    --- PASS: TestRegistryModulesListCommit/when_a_VCS_connection_is_not_present (0.47s)
        --- PASS: TestRegistryModulesListCommit/when_a_VCS_connection_is_not_present/listing_commits (0.15s)
=== RUN   TestRegistryModulesCreateWithVCSConnection
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_valid_options
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_valid_options/permissions_are_properly_decoded
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_valid_options/relationships_are_properly_decoded
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_valid_options/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_an_identifier
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_an_oauth_token_ID
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_a_display_identifier
=== RUN   TestRegistryModulesCreateWithVCSConnection/with_invalid_options/when_tags_are_enabled_and_a_branch_is_provided
=== RUN   TestRegistryModulesCreateWithVCSConnection/without_options
--- PASS: TestRegistryModulesCreateWithVCSConnection (6.10s)
    --- PASS: TestRegistryModulesCreateWithVCSConnection/with_valid_options (1.34s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_valid_options/permissions_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_valid_options/relationships_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_valid_options/timestamps_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_an_identifier (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_an_oauth_token_ID (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options/without_a_display_identifier (0.00s)
        --- PASS: TestRegistryModulesCreateWithVCSConnection/with_invalid_options/when_tags_are_enabled_and_a_branch_is_provided (0.00s)
    --- PASS: TestRegistryModulesCreateWithVCSConnection/without_options (0.00s)
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnection
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnection/with_valid_options
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnection/with_invalid_options
--- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnection (5.09s)
    --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnection/with_valid_options (1.28s)
    --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnection/with_invalid_options (0.00s)
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_valid_options
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_valid_options/tests_are_enabled
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_invalid_options
=== RUN   TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_invalid_options/when_the_the_module_is_not_branch_based_and_test_are_enabled
--- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting (5.26s)
    --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_valid_options (1.36s)
        --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_valid_options/tests_are_enabled (0.00s)
    --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_invalid_options (0.00s)
        --- PASS: TestRegistryModulesCreateBranchBasedWithVCSConnectionWithTesting/with_invalid_options/when_the_the_module_is_not_branch_based_and_test_are_enabled (0.00s)
=== RUN   TestRegistryModulesCreateWithGithubApp
    registry_module_integration_test.go:1025: Export a valid GITHUB_APP_INSTALLATION_ID before running this test!
--- SKIP: TestRegistryModulesCreateWithGithubApp (0.00s)
=== RUN   TestRegistryModulesRead
=== RUN   TestRegistryModulesRead/with_valid_name_and_provider
2023/11/06 12:13:37 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:13:37 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
=== RUN   TestRegistryModulesRead/with_valid_name_and_provider/permissions_are_properly_decoded
=== RUN   TestRegistryModulesRead/with_valid_name_and_provider/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_private_module
=== RUN   TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_private_module/permissions_are_properly_decoded
=== RUN   TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_private_module/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_public_module
=== RUN   TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_public_module/permissions_are_properly_decoded
=== RUN   TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_public_module/timestamps_are_properly_decoded
=== RUN   TestRegistryModulesRead/without_a_name
=== RUN   TestRegistryModulesRead/with_an_invalid_name
=== RUN   TestRegistryModulesRead/without_a_provider
=== RUN   TestRegistryModulesRead/with_an_invalid_provider
=== RUN   TestRegistryModulesRead/with_an_invalid_registry_name
=== RUN   TestRegistryModulesRead/without_a_valid_organization
=== RUN   TestRegistryModulesRead/without_a_valid_namespace_for_public_registry_module
=== RUN   TestRegistryModulesRead/when_the_registry_module_does_not_exist
2023/11/06 12:13:37 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:13:37 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
--- PASS: TestRegistryModulesRead (4.03s)
    --- PASS: TestRegistryModulesRead/with_valid_name_and_provider (0.17s)
        --- PASS: TestRegistryModulesRead/with_valid_name_and_provider/permissions_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesRead/with_valid_name_and_provider/timestamps_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_private_module (0.24s)
        --- PASS: TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_private_module/permissions_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_private_module/timestamps_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_public_module (0.17s)
        --- PASS: TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_public_module/permissions_are_properly_decoded (0.00s)
        --- PASS: TestRegistryModulesRead/with_complete_registry_module_ID_fields_for_public_module/timestamps_are_properly_decoded (0.00s)
    --- PASS: TestRegistryModulesRead/without_a_name (0.00s)
    --- PASS: TestRegistryModulesRead/with_an_invalid_name (0.00s)
    --- PASS: TestRegistryModulesRead/without_a_provider (0.00s)
    --- PASS: TestRegistryModulesRead/with_an_invalid_provider (0.00s)
    --- PASS: TestRegistryModulesRead/with_an_invalid_registry_name (0.00s)
    --- PASS: TestRegistryModulesRead/without_a_valid_organization (0.00s)
    --- PASS: TestRegistryModulesRead/without_a_valid_namespace_for_public_registry_module (0.00s)
    --- PASS: TestRegistryModulesRead/when_the_registry_module_does_not_exist (0.14s)
=== RUN   TestRegistryModulesDelete
=== RUN   TestRegistryModulesDelete/with_valid_name
2023/11/06 12:13:41 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:13:41 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
=== RUN   TestRegistryModulesDelete/without_a_name
=== RUN   TestRegistryModulesDelete/with_an_invalid_name
=== RUN   TestRegistryModulesDelete/without_a_valid_organization
=== RUN   TestRegistryModulesDelete/when_the_registry_module_does_not_exist
--- PASS: TestRegistryModulesDelete (2.09s)
    --- PASS: TestRegistryModulesDelete/with_valid_name (0.32s)
    --- PASS: TestRegistryModulesDelete/without_a_name (0.00s)
    --- PASS: TestRegistryModulesDelete/with_an_invalid_name (0.00s)
    --- PASS: TestRegistryModulesDelete/without_a_valid_organization (0.00s)
    --- PASS: TestRegistryModulesDelete/when_the_registry_module_does_not_exist (0.24s)
=== RUN   TestRegistryModulesDeleteProvider
=== RUN   TestRegistryModulesDeleteProvider/with_valid_name_and_provider
2023/11/06 12:13:43 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:13:43 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
=== RUN   TestRegistryModulesDeleteProvider/without_a_name
=== RUN   TestRegistryModulesDeleteProvider/with_an_invalid_name
=== RUN   TestRegistryModulesDeleteProvider/without_a_provider
=== RUN   TestRegistryModulesDeleteProvider/with_an_invalid_provider
=== RUN   TestRegistryModulesDeleteProvider/without_a_valid_organization
=== RUN   TestRegistryModulesDeleteProvider/when_the_registry_module_name_and_provider_do_not_exist
--- PASS: TestRegistryModulesDeleteProvider (2.09s)
    --- PASS: TestRegistryModulesDeleteProvider/with_valid_name_and_provider (0.31s)
    --- PASS: TestRegistryModulesDeleteProvider/without_a_name (0.00s)
    --- PASS: TestRegistryModulesDeleteProvider/with_an_invalid_name (0.00s)
    --- PASS: TestRegistryModulesDeleteProvider/without_a_provider (0.00s)
    --- PASS: TestRegistryModulesDeleteProvider/with_an_invalid_provider (0.00s)
    --- PASS: TestRegistryModulesDeleteProvider/without_a_valid_organization (0.00s)
    --- PASS: TestRegistryModulesDeleteProvider/when_the_registry_module_name_and_provider_do_not_exist (0.23s)
=== RUN   TestRegistryModulesDeleteVersion
2023/11/06 12:13:45 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:13:45 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
=== RUN   TestRegistryModulesDeleteVersion/with_valid_name_and_provider
2023/11/06 12:13:45 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:13:45 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
2023/11/06 12:13:46 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:13:46 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
=== RUN   TestRegistryModulesDeleteVersion/with_prerelease_and_metadata_version
2023/11/06 12:13:46 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:13:46 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
2023/11/06 12:13:46 [WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.
2023/11/06 12:13:46 [WARN] Support for using the RegistryModuleID without Namespace is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the Namespace in RegistryModuleID.
=== RUN   TestRegistryModulesDeleteVersion/without_a_name
=== RUN   TestRegistryModulesDeleteVersion/with_an_invalid_name
=== RUN   TestRegistryModulesDeleteVersion/without_a_provider
=== RUN   TestRegistryModulesDeleteVersion/with_an_invalid_provider
=== RUN   TestRegistryModulesDeleteVersion/without_a_version
=== RUN   TestRegistryModulesDeleteVersion/with_an_invalid_version
=== RUN   TestRegistryModulesDeleteVersion/without_a_valid_organization
=== RUN   TestRegistryModulesDeleteVersion/when_the_registry_module_name,_provider,_and_version_do_not_exist
--- PASS: TestRegistryModulesDeleteVersion (3.85s)
    --- PASS: TestRegistryModulesDeleteVersion/with_valid_name_and_provider (0.82s)
    --- PASS: TestRegistryModulesDeleteVersion/with_prerelease_and_metadata_version (0.79s)
    --- PASS: TestRegistryModulesDeleteVersion/without_a_name (0.00s)
    --- PASS: TestRegistryModulesDeleteVersion/with_an_invalid_name (0.00s)
    --- PASS: TestRegistryModulesDeleteVersion/without_a_provider (0.00s)
    --- PASS: TestRegistryModulesDeleteVersion/with_an_invalid_provider (0.00s)
    --- PASS: TestRegistryModulesDeleteVersion/without_a_version (0.00s)
    --- PASS: TestRegistryModulesDeleteVersion/with_an_invalid_version (0.00s)
    --- PASS: TestRegistryModulesDeleteVersion/without_a_valid_organization (0.00s)
    --- PASS: TestRegistryModulesDeleteVersion/when_the_registry_module_name,_provider,_and_version_do_not_exist (0.14s)
=== RUN   TestRegistryModulesUpload
=== RUN   TestRegistryModulesUpload/with_valid_upload_URL
=== RUN   TestRegistryModulesUpload/with_missing_upload_URL
--- PASS: TestRegistryModulesUpload (2.00s)
    --- PASS: TestRegistryModulesUpload/with_valid_upload_URL (0.04s)
    --- PASS: TestRegistryModulesUpload/with_missing_upload_URL (0.00s)
=== RUN   TestRegistryModulesUploadTarGzip
=== RUN   TestRegistryModulesUploadTarGzip/with_custom_go-slug
=== RUN   TestRegistryModulesUploadTarGzip/with_custom_tar_archive
--- PASS: TestRegistryModulesUploadTarGzip (2.58s)
    --- PASS: TestRegistryModulesUploadTarGzip/with_custom_go-slug (0.04s)
    --- PASS: TestRegistryModulesUploadTarGzip/with_custom_tar_archive (0.05s)
=== RUN   TestRegistryModule_Unmarshal
--- PASS: TestRegistryModule_Unmarshal (0.00s)
PASS
ok  	github.com/hashicorp/go-tfe	124.460s
...

@hashimoon hashimoon force-pushed the hashimoon/terraform-test-validations branch 2 times, most recently from f053605 to da24474 Compare November 2, 2023 23:56
Copy link
Contributor

@Uk1288 Uk1288 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏾

@hashimoon hashimoon force-pushed the hashimoon/terraform-test-validations branch from b3769d2 to 0242f49 Compare November 6, 2023 21:15
@hashimoon hashimoon changed the title wip Add validation when configuring Registry Module Publishing Nov 6, 2023
@hashimoon hashimoon force-pushed the hashimoon/terraform-test-validations branch 2 times, most recently from 6811c20 to 20c88f0 Compare November 6, 2023 21:44
Prevent setting tags to `true` when a branch is present for configuring
the VCSRepo.
@hashimoon hashimoon force-pushed the hashimoon/terraform-test-validations branch from 20c88f0 to dde8355 Compare November 6, 2023 21:45
@hashimoon hashimoon marked this pull request as ready for review November 6, 2023 21:57
@hashimoon hashimoon requested a review from a team as a code owner November 6, 2023 21:57
@hashimoon hashimoon requested a review from Uk1288 November 6, 2023 21:57
@hashimoon hashimoon changed the title Add validation when configuring Registry Module Publishing [TF-9605] Add validation when configuring Registry Module Publishing Nov 6, 2023
@hashimoon hashimoon merged commit 8bd669d into main Nov 6, 2023
11 checks passed
@hashimoon hashimoon deleted the hashimoon/terraform-test-validations branch November 6, 2023 22:34
Copy link

github-actions bot commented Nov 6, 2023

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants