Await async state version processing in TestStateVersionsUpload #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TFC does some async processing on uploaded state versions; they're not guaranteed to have `finalized` status by the time the upload call is acknowledged. That means this test flakes. (Though it wasn't flaking in CI until today, since it was previously being skipped as beta.) This adds a state version clone of the run polling function. Yeah, it's copypasta code, but it seemed premature to try and come up with some kind of ReadWithStatus interface that could cope with all the distinct string types etc. Possibly worth revisiting later.
brandonc
previously approved these changes
Nov 1, 2023
- Wasn't re-assigning from the poll output, so the test couldn't see updated result. - Expected/actual args were flipped, so fail output looked silly. - Probably no point in waiting a whole 1m.
brandonc
approved these changes
Nov 1, 2023
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TFC does some async processing on uploaded state versions; they're not guaranteed to have
finalizedstatus by the time the upload call is acknowledged. That means this test flakes. (Though it wasn't flaking in CI until today, since it was previously being skipped as beta.)This adds a state version clone of the run polling function. Yeah, it's copypasta code, but it seemed premature to try and come up with some kind of ReadWithStatus interface that could cope with all the distinct string types etc. Possibly worth revisiting later.
Testing plan
Output from tests
see CI output