Add AutoApplyRunTrigger attribute to workspaces #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfagerlund
added a commit
to hashicorp/terraform-provider-tfe
that referenced
this pull request
Oct 31, 2023
This is the commit from hashicorp/go-tfe#798, which is a prerequisite of the impending work. It should be replaced with a commit that updates go-tfe to a released version with the required feature before merge. If you see this commit log on main, someone done messed up!
2 tasks
nfagerlund
force-pushed
the
nf/oct23-auto-run-trigger
branch
from
a6b881f
to
c593200
Compare
brandonc
previously approved these changes
Nov 1, 2023
nfagerlund
added a commit
to hashicorp/terraform-provider-tfe
that referenced
this pull request
Nov 1, 2023
This is the commit from hashicorp/go-tfe#798, which is a prerequisite of the impending work. It should be replaced with a commit that updates go-tfe to a released version with the required feature before merge. If you see this commit log on main, someone done messed up!
nfagerlund
force-pushed
the
nf/oct23-auto-run-trigger
branch
2 times, most recently
from
57468bc
to
fbcc54a
Compare
nfagerlund
added a commit
to hashicorp/terraform-provider-tfe
that referenced
this pull request
Nov 1, 2023
This is the commit from hashicorp/go-tfe#798, which is a prerequisite of the impending work. It should be replaced with a commit that updates go-tfe to a released version with the required feature before merge. If you see this commit log on main, someone done messed up!
|
For posterity: we discussed in slack, and this is not in fact beta — there's a feature flag, but it's rolled out 100% to prod in TFC. |
sebasslash
reviewed
Nov 6, 2023
workspace_integration_test.go
Outdated
| @@ -506,6 +506,34 @@ func TestWorkspacesCreate(t *testing.T) { | |||
| } | |||
| }) | |||
|
|
|||
| t.Run("with valid auto-apply-run-trigger option", func(t *testing.T) { | |||
| skipUnlessBeta(t) | |||
There was a problem hiding this comment.
If this is no longer beta, but only available in TFC we should use the skipIfEnterprise() helper
There was a problem hiding this comment.
omg. yeah, thank you!
nfagerlund
force-pushed
the
nf/oct23-auto-run-trigger
branch
from
fbcc54a
to
c48d728
Compare
sebasslash
previously approved these changes
Nov 6, 2023
laurenolivia
approved these changes
Nov 7, 2023
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support the new auto-apply-run-trigger workspace attribute, which is exactly like auto-apply except it has to be a new attribute to avoid surprising anyone accustomed to the prior behavior of hard-denying auto-apply for run triggers.
This feature is shipped to TFC prod, but not yet available in TFE.
Testing plan
External links
Output from tests
I'm internal, check CI.