Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Test Runs test suite #795

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Fix Test Runs test suite #795

merged 3 commits into from
Nov 1, 2023

Conversation

aaabdelgany
Copy link
Contributor

Description

This PR fixes the test suite for test runs by enabling tests via the TestConfig object.

External links

https://developer.hashicorp.com/terraform/cloud-docs/api-docs/private-registry/modules#update-a-private-registry-module

Output from tests

go test -run TestTestRun -v
=== RUN   TestTestRunsList
=== RUN   TestTestRunsList/without_list_options
=== RUN   TestTestRunsList/empty_list_options
=== RUN   TestTestRunsList/with_page_size
--- PASS: TestTestRunsList (12.42s)
    --- PASS: TestTestRunsList/without_list_options (0.34s)
    --- PASS: TestTestRunsList/empty_list_options (0.60s)
    --- PASS: TestTestRunsList/with_page_size (0.22s)
=== RUN   TestTestRunsRead
=== RUN   TestTestRunsRead/when_the_test_run_exists
=== RUN   TestTestRunsRead/when_the_test_run_does_not_exist
--- PASS: TestTestRunsRead (6.34s)
    --- PASS: TestTestRunsRead/when_the_test_run_exists (0.22s)
    --- PASS: TestTestRunsRead/when_the_test_run_does_not_exist (0.30s)
=== RUN   TestTestRunsCreate
=== RUN   TestTestRunsCreate/with_a_configuration_version
=== RUN   TestTestRunsCreate/without_a_configuration_version
=== RUN   TestTestRunsCreate/without_a_module
=== RUN   TestTestRunsCreate/without_an_organisation
--- PASS: TestTestRunsCreate (6.35s)
    --- PASS: TestTestRunsCreate/with_a_configuration_version (0.34s)
    --- PASS: TestTestRunsCreate/without_a_configuration_version (0.00s)
    --- PASS: TestTestRunsCreate/without_a_module (0.00s)
    --- PASS: TestTestRunsCreate/without_an_organisation (0.00s)
=== RUN   TestTestRunsLogs
=== RUN   TestTestRunsLogs/when_the_log_exists
=== RUN   TestTestRunsLogs/when_the_log_does_not_exist
--- PASS: TestTestRunsLogs (28.55s)
    --- PASS: TestTestRunsLogs/when_the_log_exists (22.74s)
    --- PASS: TestTestRunsLogs/when_the_log_does_not_exist (0.17s)
=== RUN   TestTestRunsCancel
=== RUN   TestTestRunsCancel/when_the_run_exists
=== RUN   TestTestRunsCancel/when_the_run_does_not_exist
--- PASS: TestTestRunsCancel (6.04s)
    --- PASS: TestTestRunsCancel/when_the_run_exists (0.24s)
    --- PASS: TestTestRunsCancel/when_the_run_does_not_exist (0.29s)
PASS
ok  	github.com/hashicorp/go-tfe	59.888s

@aaabdelgany aaabdelgany requested a review from a team as a code owner October 23, 2023 18:10
brandonc
brandonc previously approved these changes Nov 1, 2023
CHANGELOG.md Outdated
Comment on lines 8 to 9
## Bug Fixes
* Fixed test run test suite by enabling tests on the branch based module helper function.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't mind removing; I don't think I see a need for release notes about unit test additions 🙃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaabdelgany aaabdelgany merged commit 1134435 into main Nov 1, 2023
10 checks passed
@aaabdelgany aaabdelgany deleted the abdu/fix_test_runs_tests branch November 1, 2023 19:53
Copy link

github-actions bot commented Nov 1, 2023

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants