Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for creating and filtering workspace scoped agent pools #682

Merged

Conversation

hs26gill
Copy link
Contributor

@hs26gill hs26gill commented Apr 17, 2023

Description

Atlas enables the creation of agent pools that are tailored to specific workspaces, rather than being on the organization level. With this pull request, users can specify the OrganizationScoped and AllowedWorkspaces fields to establish a scope for the agent pool that includes only the permitted workspaces. Additionally, a AllowedWorkspacesName filter has been included to facilitate the listing of Agent Pools that are associated with a specific workspace.

Testing plan

Verify that all tests still pass.

External links

Output from tests

=== RUN   TestAgentPoolsList
--- PASS: TestAgentPoolsList (9.52s)
=== RUN   TestAgentPoolsList/without_list_options
    --- PASS: TestAgentPoolsList/without_list_options (0.46s)
=== RUN   TestAgentPoolsList/with_Include_option
    helper_test.go:806: Export a valid OAUTH_CLIENT_GITHUB_TOKEN before running this test!
    --- SKIP: TestAgentPoolsList/with_Include_option (0.00s)

Test ignored.
=== RUN   TestAgentPoolsList/with_list_options
    --- PASS: TestAgentPoolsList/with_list_options (0.32s)
=== RUN   TestAgentPoolsList/without_a_valid_organization
    --- PASS: TestAgentPoolsList/without_a_valid_organization (0.00s)
=== RUN   TestAgentPoolsList/with_query_options
    --- PASS: TestAgentPoolsList/with_query_options (0.76s)
=== RUN   TestAgentPoolsList/with_allowed_workspace_name_filter
    --- PASS: TestAgentPoolsList/with_allowed_workspace_name_filter (3.34s)

Test ignored.
PASS


=== RUN   TestAgentPoolsCreate
--- PASS: TestAgentPoolsCreate (4.57s)
=== RUN   TestAgentPoolsCreate/with_valid_options
    --- PASS: TestAgentPoolsCreate/with_valid_options (1.11s)
=== RUN   TestAgentPoolsCreate/when_options_is_missing_name
    --- PASS: TestAgentPoolsCreate/when_options_is_missing_name (0.00s)
=== RUN   TestAgentPoolsCreate/with_an_invalid_organization
    --- PASS: TestAgentPoolsCreate/with_an_invalid_organization (0.00s)
=== RUN   TestAgentPoolsCreate/with_allowed-workspaces_options
    --- PASS: TestAgentPoolsCreate/with_allowed-workspaces_options (1.46s)
PASS

@hs26gill hs26gill force-pushed the hs26gill/TF-3175-add-scoping-agent-pools-to-workspaces branch 2 times, most recently from 4506c5a to b770b65 Compare April 17, 2023 14:47
@hs26gill hs26gill self-assigned this Apr 17, 2023
@hs26gill hs26gill marked this pull request as ready for review April 17, 2023 14:48
@hs26gill hs26gill requested a review from a team as a code owner April 17, 2023 14:48
uturunku1
uturunku1 previously approved these changes Apr 24, 2023
agent_pool.go Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@hs26gill hs26gill force-pushed the hs26gill/TF-3175-add-scoping-agent-pools-to-workspaces branch 2 times, most recently from 6405abf to a87d581 Compare April 25, 2023 19:46
@uturunku1 uturunku1 self-requested a review April 25, 2023 19:50
uturunku1
uturunku1 previously approved these changes Apr 25, 2023
@hs26gill hs26gill force-pushed the hs26gill/TF-3175-add-scoping-agent-pools-to-workspaces branch 2 times, most recently from edf5ae4 to 909908c Compare April 26, 2023 20:26
@hs26gill hs26gill force-pushed the hs26gill/TF-3175-add-scoping-agent-pools-to-workspaces branch from 909908c to 93aa2cb Compare April 27, 2023 13:36
Copy link
Contributor

@laurenolivia laurenolivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hs26gill hs26gill merged commit 494e8df into main Apr 27, 2023
10 checks passed
@hs26gill hs26gill deleted the hs26gill/TF-3175-add-scoping-agent-pools-to-workspaces branch April 27, 2023 14:50
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants