Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix or ignore all outsanding golangci-lint errors #597

Merged
merged 3 commits into from Nov 30, 2022
Merged

Fix or ignore all outsanding golangci-lint errors #597

merged 3 commits into from Nov 30, 2022

Commits on Nov 30, 2022

  1. Fix or ignore all outsanding golangci-lint errors 

    As reported by "make lint"

Also fixed incorrect build tag in two tests that were causing the tests to be skipped

Thanks to @estenssoros for the efforts to improve the code!

Co-Authored-By: Sebastian Estenssoro <seb.estenssoro@gmail.com>
    @brandonc @estenssoros
    brandonc and estenssoros committed Nov 30, 2022
    Copy the full SHA
    003c38e View commit details
    Browse the repository at this point in the history

  2. Is the linter GHA broken?

    @brandonc
    brandonc committed Nov 30, 2022
    Copy the full SHA
    db37cb5 View commit details
    Browse the repository at this point in the history

  3. Update golangci-lint.yml

    @brandonc
    brandonc committed Nov 30, 2022
    Copy the full SHA
    983c77a View commit details
    Browse the repository at this point in the history