Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add force execute for a run #570

Merged
merged 1 commit into from Nov 1, 2022
Merged

Add force execute for a run #570

merged 1 commit into from Nov 1, 2022

Conversation

annawinkler
Copy link
Contributor

@annawinkler annawinkler commented Oct 28, 2022 •
edited

Description

Add ForceExecute for a run.

Testing plan

  1. Create a workspace
  2. Create a run and make sure it's pending
  3. Create a second run, and ForceExecute the run
  4. Verify the second run has a status that is applyable (cost estimated or planned)

External links

Output from tests

❯ envchain tfe-local go test -run TestRunsForceExecute -v ./... -tags=integration

=== RUN   TestRunsForceExecute
    helper_test.go:928: Polling run "run-ZuWKxopadhyBSoKQ" for status included in ["cost_estimated" "errored"] with deadline of 2022-11-01 12:09:04.016706 -0600 MDT m=+123.207022584
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "cost_estimating"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-ZuWKxopadhyBSoKQ"
    helper_test.go:940: Run "run-ZuWKxopadhyBSoKQ" had status "cost_estimated"
    helper_test.go:928: Polling run "run-MW8nisyjdhg8Utz4" for status included in ["pending" "errored"] with deadline of 2022-11-01 12:09:43.907218 -0600 MDT m=+163.097441917
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "pending"
=== RUN   TestRunsForceExecute/a_successful_force-execute
    helper_test.go:928: Polling run "run-MW8nisyjdhg8Utz4" for status included in ["cost_estimated"] with deadline of 2022-11-01 12:09:46.835586 -0600 MDT m=+166.025803876
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "planning"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "cost_estimating"
    helper_test.go:934: ...
    helper_test.go:955: Reading run "run-MW8nisyjdhg8Utz4"
    helper_test.go:940: Run "run-MW8nisyjdhg8Utz4" had status "cost_estimated"
=== RUN   TestRunsForceExecute/when_the_run_does_not_exist
=== RUN   TestRunsForceExecute/with_invalid_run_ID
--- PASS: TestRunsForceExecute (86.17s)
    --- PASS: TestRunsForceExecute/a_successful_force-execute (39.36s)
    --- PASS: TestRunsForceExecute/when_the_run_does_not_exist (0.20s)
    --- PASS: TestRunsForceExecute/with_invalid_run_ID (0.00s)
PASS
ok  	github.com/hashicorp/go-tfe	86.901s
?   	github.com/hashicorp/go-tfe/examples/organizations	[no test files]
?   	github.com/hashicorp/go-tfe/examples/workspaces	[no test files]
?   	github.com/hashicorp/go-tfe/mocks	[no test files]

Feels gif

@annawinkler annawinkler force-pushed the aw/force-execute-run branch 2 times, most recently from f490260 to 3f41a28 Compare November 1, 2022 18:06
@annawinkler annawinkler marked this pull request as ready for review November 1, 2022 18:10
@annawinkler annawinkler requested a review from a team as a code owner November 1, 2022 18:10
brandonc
brandonc reviewed Nov 1, 2022
View reviewed changes
run.go Outdated Show resolved Hide resolved
@annawinkler annawinkler merged commit 6777fea into main Nov 1, 2022
@annawinkler annawinkler deleted the aw/force-execute-run branch November 1, 2022 23:22
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

@annawinkler annawinkler mentioned this pull request Nov 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonc brandonc brandonc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@annawinkler @brandonc