Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRUD support for Projects API #564

Merged
merged 10 commits into from Nov 29, 2022
Merged

Conversation

hs26gill
Copy link
Contributor

@hs26gill hs26gill commented Oct 25, 2022

Description

A new Projects API is added to allow users to organize and centrally manage their workspaces at scale.

Testing plan

To run the integration test:

ENABLE_BETA=1 go test -run TestProjectsRead  -v ./... -tags=integration

ENABLE_BETA=1 go test -run TestProjectsCreate  -v ./... -tags=integration

ENABLE_BETA=1 go test -run TestProjectsUpdate -v ./... -tags=integration

ENABLE_BETA=1 go test -run TestProjectsDelete  -v ./... -tags=integration

ENABLE_BETA=1 go test -run TestProjectsList  -v ./... -tags=integration

@hs26gill hs26gill force-pushed the hs26gill/add-projects-api-support branch 3 times, most recently from 0ebc00a to c52575e Compare November 1, 2022 21:01
@hs26gill hs26gill changed the title WIP: Add CRUD API support for Projects Add CRUD support for Projects API Nov 1, 2022
@hs26gill hs26gill marked this pull request as ready for review November 1, 2022 21:40
@hs26gill hs26gill requested a review from a team as a code owner November 1, 2022 21:40
Copy link
Contributor

@jbonhag jbonhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done -- a couple of nitpick/naming-related things but it seems to be in good shape!

projects.go Outdated Show resolved Hide resolved
tfe.go Outdated Show resolved Hide resolved
workspace_integration_test.go Show resolved Hide resolved
projects.go Outdated Show resolved Hide resolved
@hs26gill hs26gill force-pushed the hs26gill/add-projects-api-support branch from 87fd140 to 64d7011 Compare November 8, 2022 01:31
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving in the right direction 🕺 Some comments down below 😄

organization_integration_test.go Outdated Show resolved Hide resolved
project.go Outdated Show resolved Hide resolved
project.go Outdated Show resolved Hide resolved
project.go Outdated Show resolved Hide resolved
projects_integration_test.go Outdated Show resolved Hide resolved
workspace_integration_test.go Outdated Show resolved Hide resolved
workspace_integration_test.go Show resolved Hide resolved
@hs26gill hs26gill force-pushed the hs26gill/add-projects-api-support branch from 64d7011 to 22719f1 Compare November 17, 2022 18:49
Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this looks great. My one bit of blocking feedback is that all the new go docs need to be clearly labeled as beta, and the CHANGELOG should make it clear that the features are not generally available and subject to change.

Ex:

type Projects interface
    // List all projects in the given organization
    // **Note: This field is still in BETA and subject to change.**
    List(ctx...)
...
}

See the Adding API Changes that are Not Generally Available section of CONTRIBUTING.md for details.

project.go Outdated Show resolved Hide resolved
@sebasslash sebasslash dismissed their stale review November 29, 2022 15:25

Changes addressed

@hs26gill hs26gill merged commit 1a66ad2 into main Nov 29, 2022
@hs26gill hs26gill deleted the hs26gill/add-projects-api-support branch November 29, 2022 15:27
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants