Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new strings for Assessment Notification Triggers #533

Closed
wants to merge 2 commits into from

Conversation

lawliet89
Copy link
Contributor

@lawliet89 lawliet89 commented Sep 16, 2022

Description

Add new assessment trigger notifications for workspace assessment that just went GA.

Would like to use these strings in the Terraform TFE Provider.

Testing plan

Add these new triggers to notifications.

External links

https://www.terraform.io/cloud-docs/api-docs/notification-configurations#notification-triggers

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" TF_ACC="1" go test ./... -v -tags=integration -run TestFunctionsAffectedByChange

...

There are no particular tests for trigger types.

@lawliet89 lawliet89 requested a review from a team as a code owner September 16, 2022 23:43
Copy link
Contributor

@laurenolivia laurenolivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PRing this ⭐

@lawliet89
Copy link
Contributor Author

Test is failing due to 2022/09/26 21:09:46 missing API token

@annawinkler
Copy link
Contributor

Test is failing due to 2022/09/26 21:09:46 missing API token

Yeah, we need a better story for how to get the tests to run for contributed PRs. cc @barrettclark

@laurenolivia
Copy link
Contributor

This PR was merged under a different branch. See PR #542

@lawliet89 lawliet89 deleted the assessement-trigger branch October 7, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants