Filter teams by name, org members by email #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uk1288
reviewed
May 4, 2022
|
|
||
| // validEmail checks if the given input is a correct email | ||
| func validEmail(v string) bool { | ||
| _, err := mail.ParseAddress(v) |
Uk1288
reviewed
May 4, 2022
| @@ -77,6 +77,9 @@ type OrganizationMembershipListOptions struct { | |||
| // Optional: A list of relations to include. See available resources | |||
| // https://www.terraform.io/cloud-docs/api-docs/organization-memberships#available-related-resources | |||
| Include []OrgMembershipIncludeOpt `url:"include,omitempty"` | |||
|
|
|||
| // Optional: A list of organization member emails to filter by. | |||
| Emails []string `url:"filter[email],omitempty"` | |||
There was a problem hiding this comment.
should this be,
Suggested change
| Emails []string `url:"filter[email],omitempty"` | |
| Emails []string `url:"filter[emails],omitempty"` |
There was a problem hiding this comment.
👋 The param in the API is actually filter[email]: https://www.terraform.io/cloud-docs/api-docs/organization-memberships#query-parameters
brandonc
previously approved these changes
May 4, 2022
| @@ -278,3 +285,13 @@ func validateTeamIncludeParams(params []TeamIncludeOpt) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func validateTeamNames(names []string) error { | |||
| for _, name := range names { | |||
There was a problem hiding this comment.
This works when names is nil, right?
annawinkler
reviewed
May 5, 2022
| @@ -262,4 +262,8 @@ var ( | |||
| ErrRequiredWorkspacesList = errors.New("no workspaces list provided") | |||
|
|
|||
| ErrCommentBody = errors.New("comment body is required") | |||
|
|
|||
| ErrEmptyTeamName = errors.New("team name can not be empty") | |||
There was a problem hiding this comment.
Suggested change
| ErrEmptyTeamName = errors.New("team name can not be empty") | |
| ErrEmptyTeamName = errors.New("team name cannot be empty") |
There was a problem hiding this comment.
I'm asking @laurapacilio about this because ... after doing a quick search I realized that this suggestion may not be consistent with what we do as a company.
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new query params have been added to the list endpoints for
TeamsandOrganizationMemberships:filter[names]- List Teamsfilter[email]- List Org Members