Update changelog for Run Tasks API changes #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the beta API changes for the Run Tasks entitlement as per RFC TF-479: * Add run-tasks to Organization entitlement set This commit also adds tests for this beta feature.
cam-stitt
approved these changes
May 4, 2022
sebasslash
previously requested changes
May 4, 2022
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| * Adds support for reading current state version outputs to StateVersionOutputs, which can be useful for reading outputs when users don't have the necessary permissions to read the entire state. | |||
| * Adds Variable Set methods for `ApplyToWorkspaces` and `RemoveFromWorkspaces` [#375](https://github.com/hashicorp/go-tfe/pull/375) | |||
| * Adds Run Tasks API support by @glennsarti [#381](https://github.com/hashicorp/go-tfe/pull/381), [#382](https://github.com/hashicorp/go-tfe/pull/382) and [#383](https://github.com/hashicorp/go-tfe/pull/383) | |||
There was a problem hiding this comment.
I would split this entry into 3 for each run task change you made:
* Add Run Task permissions field to `Organization` and `Workspace` by @glennsarti [#383](https://github.com/hashicorp/go-tfe/pull/383)
* Add Run Task field to `Entitlement` struct [#381](https://github.com/hashicorp/go-tfe/pull/381)
* Add `Enabled` field to `RunTask` struct [#382](https://github.com/hashicorp/go-tfe/pull/382)
There was a problem hiding this comment.
We haven't previously mentioned run tasks at all in the changelog.
There was a problem hiding this comment.
I think it would be OK to just say "Run tasks!" and I'm in favor of keeping the original version.
There was a problem hiding this comment.
Ah! I was only looking in CHANGELOG. You're right. We did label it "beta" so this is still fine, I guess.
brandonc
approved these changes
May 4, 2022
sebasslash
dismissed
their stale review
Requested changes have been rendered moot :)
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #381 being merged first
Changelog Update for the work on Run Tasks API
Description
Changelog update