Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are a few endpoints which use nested identifiers to identify a resource rather than using the external ID of that resource. As of now the Module Registry API seems to follow this type of pattern, e.g
POST /organizations/:organization_name/registry-modules/:registry_name/:namespace/:name/:provider/versions
In order to keep method signatures readable, I've refactored these nested URL params into structs which represent the set of identifiers used when referencing a resource. The example above would look something like:
Not only does this help keep our method signatures compact, but it enables us to keep our validations DRY for more consistency.