Skip to content

Commit

Permalink
Merge pull request #521 from hashicorp/null-varset-relationship
Browse files Browse the repository at this point in the history
Fix struct tag for varset relationship
  • Loading branch information
sebasslash committed Sep 6, 2022
2 parents 1137df1 + 34b6e80 commit fba8069
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
@@ -1,3 +1,8 @@
# Unreleased

## Bug Fixes
* Fixes null value returned in variable set relationship in `VariableSetVariable` by @sebasslash [#521](https://github.com/hashicorp/go-tfe/pull/521)

# v1.9.0

## Enhancements
Expand Down
2 changes: 1 addition & 1 deletion variable_set_variable.go
Expand Up @@ -49,7 +49,7 @@ type VariableSetVariable struct {
Sensitive bool `jsonapi:"attr,sensitive"`

// Relations
VariableSet *VariableSet `jsonapi:"relation,configurable"`
VariableSet *VariableSet `jsonapi:"relation,varset"`
}

type VariableSetVariableListOptions struct {
Expand Down
8 changes: 5 additions & 3 deletions variable_set_variable_test.go
Expand Up @@ -34,12 +34,14 @@ func TestVariableSetVariablesList(t *testing.T) {
t.Run("without list options", func(t *testing.T) {
vl, err := client.VariableSetVariables.List(ctx, vsTest.ID, nil)
require.NoError(t, err)
require.NotEmpty(t, vl.Items)
assert.Contains(t, vl.Items, vTest1)
assert.Contains(t, vl.Items, vTest2)

t.Skip("paging not supported yet in API")
assert.Equal(t, 1, vl.CurrentPage)
assert.Equal(t, 2, vl.TotalCount)
t.Run("variable set relationship is deserialized", func(t *testing.T) {
require.NotNil(t, vl.Items[0].VariableSet)
assert.Equal(t, vsTest.ID, vl.Items[0].VariableSet.ID)
})
})

t.Run("with list options", func(t *testing.T) {
Expand Down

0 comments on commit fba8069

Please sign in to comment.