Merge pull request #369 from JarrettSpiker/SsoTeamStringRef

Change Team SSOTeamID property from a pointer to a string

team.go

@@ -49,7 +49,7 @@ type Team struct {
 	Visibility         string              `jsonapi:"attr,visibility"`
 	Permissions        *TeamPermissions    `jsonapi:"attr,permissions"`
 	UserCount          int                 `jsonapi:"attr,users-count"`
-	SSOTeamID          *string             `jsonapi:"attr,sso-team-id"`
+	SSOTeamID          string              `jsonapi:"attr,sso-team-id"`
 
 	// Relations
 	Users                   []*User                   `jsonapi:"relation,users"`

team_integration_test.go

@@ -121,8 +121,8 @@ func TestTeamsCreate(t *testing.T) {
 		assert.Nil(t, err)
 		assert.Equal(t, *options.Name, team.Name)
 
-		assert.NotNil(t, options.SSOTeamID, team.SSOTeamID)
-		assert.Equal(t, *options.SSOTeamID, *team.SSOTeamID)
+		assert.NotNil(t, team.SSOTeamID)
+		assert.Equal(t, *options.SSOTeamID, team.SSOTeamID)
 	})
 
 	t.Run("when options is missing name", func(t *testing.T) {
@@ -185,7 +185,7 @@ func TestTeamsRead(t *testing.T) {
 
 		t.Run("SSO team id is returned", func(t *testing.T) {
 			assert.NotNil(t, ssoTeam.SSOTeamID)
-			assert.Equal(t, *opts.SSOTeamID, *ssoTeam.SSOTeamID)
+			assert.Equal(t, *opts.SSOTeamID, ssoTeam.SSOTeamID)
 		})
 	})
 
@@ -336,7 +336,7 @@ func TestTeam_Unmarshal(t *testing.T) {
 	require.NoError(t, err)
 	assert.Equal(t, team.ID, "1")
 	assert.Equal(t, team.Name, "team hashi")
-	assert.Nil(t, team.SSOTeamID)
+	assert.Empty(t, team.SSOTeamID)
 	assert.Equal(t, team.OrganizationAccess.ManageWorkspaces, true)
 	assert.Equal(t, team.OrganizationAccess.ManageVCSSettings, true)
 	assert.Equal(t, team.OrganizationAccess.ManagePolicies, true)