Simplify test per PR feedback

registry_provider_integration_test.go

@@ -59,36 +59,20 @@ func TestRegistryProvidersList(t *testing.T) {
 			}
 		})
 
-		t.Run("returns pages", func(t *testing.T) {
-			pageN := 2
-			pageSize := providerN / pageN
-
-			for page := 0; page < pageN; page++ {
-				testName := fmt.Sprintf("returns page %d of providers", page)
-				t.Run(testName, func(t *testing.T) {
-					returnedProviders, err := client.RegistryProviders.List(ctx, orgTest.Name, &RegistryProviderListOptions{
-						ListOptions: ListOptions{
-							PageNumber: page,
-							PageSize:   pageSize,
-						},
-					})
-					require.NoError(t, err)
-					assert.NotEmpty(t, returnedProviders.Items)
-					assert.Equal(t, providerN, returnedProviders.TotalCount)
-					assert.Equal(t, pageN, returnedProviders.TotalPages)
-					assert.Equal(t, pageSize, len(returnedProviders.Items))
-					for _, rp := range returnedProviders.Items {
-						foundProvider := false
-						for _, p := range providers {
-							if rp.ID == p.ID {
-								foundProvider = true
-								break
-							}
-						}
-						assert.True(t, foundProvider, "Expected to find provider %s but did not:\nexpected:\n%v\nreturned\n%v", rp.ID, providers, returnedProviders)
-					}
-				})
-			}
+		t.Run("with list options", func(t *testing.T) {
+			// Request a page number which is out of range. The result should
+			// be successful, but return no results if the paging options are
+			// properly passed along.
+			rpl, err := client.RegistryProviders.List(ctx, orgTest.Name, &RegistryProviderListOptions{
+				ListOptions: ListOptions{
+					PageNumber: 999,
+					PageSize:   100,
+				},
+			})
+			require.NoError(t, err)
+			assert.Empty(t, rpl.Items)
+			assert.Equal(t, 999, rpl.CurrentPage)
+			assert.Equal(t, 2, rpl.TotalCount)
 		})
 
 		t.Run("filters on registry name", func(t *testing.T) {