Skip to content

Commit

Permalink
Fixes project names being validated as IDs
Browse files Browse the repository at this point in the history
  • Loading branch information
brandonc committed Dec 8, 2022
1 parent 6c89799 commit 69ff5d2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 11 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
@@ -1,7 +1,9 @@
# Unreleased
# v1.15.1

## Bug Fixes

* Project names were being validated as ID's

## Enhancements

# v1.15.0
Expand Down
7 changes: 0 additions & 7 deletions project.go
Expand Up @@ -203,16 +203,9 @@ func (o ProjectCreateOptions) valid() error {
if !validString(&o.Name) {
return ErrRequiredName
}

if !validStringID(&o.Name) {
return ErrInvalidName
}
return nil
}

func (o ProjectUpdateOptions) valid() error {
if o.Name != nil && !validStringID(o.Name) {
return ErrInvalidName
}
return nil
}
6 changes: 3 additions & 3 deletions projects_integration_test.go
Expand Up @@ -123,7 +123,7 @@ func TestProjectsCreate(t *testing.T) {
Name: badIdentifier,
})
assert.Nil(t, w)
assert.EqualError(t, err, ErrInvalidName.Error())
assert.Contains(t, err.Error(), "invalid attribute\n\nName may only contain")
})

t.Run("when options has an invalid organization", func(t *testing.T) {
Expand All @@ -149,7 +149,7 @@ func TestProjectsUpdate(t *testing.T) {
defer kTestCleanup()

kAfter, err := client.Projects.Update(ctx, kBefore.ID, ProjectUpdateOptions{
Name: String("new_project_name"),
Name: String("new project name!"),
})
require.NoError(t, err)

Expand All @@ -165,7 +165,7 @@ func TestProjectsUpdate(t *testing.T) {
Name: String(badIdentifier),
})
assert.Nil(t, kAfter)
assert.EqualError(t, err, ErrInvalidName.Error())
assert.Contains(t, err.Error(), "invalid attribute\n\nName may only contain")
})

t.Run("without a valid projects ID", func(t *testing.T) {
Expand Down

0 comments on commit 69ff5d2

Please sign in to comment.