Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StrListDelete side effect. #118

Merged
merged 6 commits into from
Feb 9, 2024
Merged

Fix StrListDelete side effect. #118

merged 6 commits into from
Feb 9, 2024

Conversation

ncabatoff
Copy link
Contributor

No description provided.

jasonodonnell
jasonodonnell approved these changes Feb 6, 2024
View reviewed changes
Copy link

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Go mod seems unrelated?

@ncabatoff
Copy link
Contributor Author

Oh yeah, that's from an earlier attempt using slices. Will remove.

tomcf-hcp
tomcf-hcp requested changes Feb 6, 2024
View reviewed changes
Copy link

@tomcf-hcp tomcf-hcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding these changes to the playground did not change side effects.

strutil/strutil.go Show resolved Hide resolved
@averche
Copy link

averche commented Feb 6, 2024

It would also be great to enhance this test to ensure the original slice is not modified.

@ncabatoff
Copy link
Contributor Author

It would also be great to enhance this test to ensure the original slice is not modified.

Done.

averche
averche approved these changes Feb 7, 2024
View reviewed changes
strutil/strutil_test.go Show resolved Hide resolved
@ncabatoff ncabatoff merged commit 4321d38 into main Feb 9, 2024
20 checks passed
@ncabatoff ncabatoff deleted the fix-strlistdelete branch February 9, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonodonnell jasonodonnell jasonodonnell approved these changes

@averche averche averche approved these changes

@tomcf-hcp tomcf-hcp tomcf-hcp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ncabatoff @averche @jasonodonnell @tomcf-hcp