Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set a custom identity token fetcher implementation #116

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

vinay-gopalan
Copy link
Contributor

This PR introduces the ability to set a custom token fetcher in the awsutil/v0 package. This PR involves adding the token fetcher to the credential config and ensuring that the token fetcher can be used by to generate the credential chain if provided in the cred config.

The actual token fetcher implementation that fetches the Identity Token is in Vault here:

@vinay-gopalan vinay-gopalan requested a review from a team January 22, 2024 23:29
@vinay-gopalan vinay-gopalan changed the title Add ability to set a custom identity token fetcher implementation for the AWS SDK to consume Add ability to set a custom identity token fetcher implementation Jan 22, 2024
Copy link
Member

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise! Thanks @vinay-gopalan

awsutil/generate_credentials.go Show resolved Hide resolved
awsutil/generate_credentials.go Show resolved Hide resolved
awsutil/generate_credentials.go Outdated Show resolved Hide resolved
@vinay-gopalan vinay-gopalan merged commit 44cae24 into awsutil/v0 Jan 24, 2024
18 checks passed
@vinay-gopalan vinay-gopalan deleted the VAULT-23359/add-identiy-token-fetcher branch January 24, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants