Read AWS_PROFILE to enable Shared Credentials provider
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
reviewed
Sep 22, 2021
jefferai
approved these changes
Sep 23, 2021
|
Tagged |
|
How can I tell if this fix is part of vault release? I am currently on vault 1.9.1 and the issue reported in hashicorp/vault#5767 is not fixed for me. |
|
Hey @vinay-gopalan do you have a test case which this issue was determined to be fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the Profile field that already existed in the AWS Credentials Config. It reads from the
AWS_PROFILEenvironment variable and uses this value in theGenerateCredentialChainmethod to enable the Shared Credentials Provider.The addition of these changes allows the use of
source_profilefields that point to a named profile with credentials for assuming roles. This aims to fix: