client.baseRetryPolicy check if response is nil before accessing attributes #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
manicminer
requested changes
May 9, 2024
There was a problem hiding this comment.
@tty2 Thanks for submitting this PR. I agree we should be nil-checking the response, however I'd suggest that the request should be retried in that circumstance, since a nil response is often attributed to the connection being closed or the server misbehaving - both temporary conditions that IMO we should smooth over.
Co-authored-by: Tom Bamford <tom@bamford.io>
Co-authored-by: Tom Bamford <tom@bamford.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
baseRetryPolicyis accessable from publicDefaultRetryPolicyandErrorPropagatedRetryPolicyand it is called without any checks.There is possible case with call this function with passing nil
*http.Responseinside and catchpanic.With this changes they get error with explanation.