Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid reading all from bytes.Reader when get request body #197

Merged
merged 2 commits into from May 9, 2024
Merged

Avoid reading all from bytes.Reader when get request body #197

merged 2 commits into from May 9, 2024

Conversation

longshine
Copy link
Contributor

Avoid reading all bytes from bytes.Reader to save memory.

See also Request.NewRequestWithContext() in net/http.

Ref: https://github.com/golang/go/blob/e71b61180aa19a60c23b3b7e3f6586726ebe4fd1/src/net/http/request.go#L881-L887

@longshine longshine requested a review from a team as a code owner May 19, 2023 08:58
@longshine longshine requested review from smacfarlane and jeanneryan and removed request for a team May 19, 2023 08:58
@hashicorp-cla
Copy link

hashicorp-cla commented May 19, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@longshine longshine requested a review from a team as a code owner May 9, 2024 14:02
manicminer
manicminer approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement @longshine, this LGTM 👍

@manicminer manicminer added this to the v0.7.6 milestone May 9, 2024
@manicminer manicminer merged commit 8db2bb6 into hashicorp:main May 9, 2024
1 check passed
manicminer added a commit that referenced this pull request May 9, 2024
@manicminer
Changelog updates for #138, #197, #216
6d0f2e8
manicminer added a commit that referenced this pull request May 9, 2024
@manicminer
Merge pull request #223 from hashicorp/manicminer-patch-1
e6c9acc 
Changelog updates for #138, #197, #216
@longshine longshine deleted the avoid-read-from-bytes-reader branch May 10, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manicminer manicminer manicminer approved these changes

@smacfarlane smacfarlane Awaiting requested review from smacfarlane smacfarlane was automatically assigned from hashicorp/release-engineering

@jeanneryan jeanneryan Awaiting requested review from jeanneryan jeanneryan was automatically assigned from hashicorp/release-engineering

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.7.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@longshine @hashicorp-cla @manicminer