Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Group.SetLimit(n int) #94

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add Group.SetLimit(n int) #94

wants to merge 1 commit into from

Conversation

markus-wa
Copy link

This allows us to control the max number of goroutines that can be ran concurrently

@markus-wa markus-wa requested a review from a team as a code owner February 13, 2024 17:22
@markus-wa
Copy link
Author

note: golang.org/x/sync/errgroup already has this functionality - but unfortunately they only return the first error when more than one occurred - so I figured it made sense to add the SetLimit functionality here instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahethompson sarahethompson Awaiting requested review from sarahethompson sarahethompson is a code owner automatically assigned from hashicorp/release-engineering

@emilymianeil emilymianeil Awaiting requested review from emilymianeil emilymianeil is a code owner automatically assigned from hashicorp/release-engineering

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@markus-wa