-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve nil value when no errors have occurred. #8
Open
mspiegel
wants to merge
13
commits into
hashicorp:main
Choose a base branch
from
mspiegel:master
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Aug 11, 2016
-
Preserve nil value when no errors have occurred.
This patch handles nil values when passed into the slice argument of AppendNonNil(err error, errs ...error). nil values are filtered out and not included in the multierror. When the first argument to AppendNonNil is nil, and the second argument consists entirely of nil values, then return a nil value. This patch allows the usage the following style. ``` var result error result = multierror.AppendNonNil(result, step1()) result = multierror.AppendNonNil(result, step2()) return result ``` result will be nil if-and-only-if step1() and step2() both return nil.
Configuration menu - View commit details
-
Copy full SHA for fa33db1 - Browse repository at this point
Copy the full SHA fa33db1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e17297 - Browse repository at this point
Copy the full SHA 1e17297View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35878e7 - Browse repository at this point
Copy the full SHA 35878e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6146a39 - Browse repository at this point
Copy the full SHA 6146a39View commit details -
Configuration menu - View commit details
-
Copy full SHA for a20743b - Browse repository at this point
Copy the full SHA a20743bView commit details -
Another AppendNonNil interface bugfix.
Do not convert 'nil' error to 'nil' *Error.
Configuration menu - View commit details
-
Copy full SHA for c2714b7 - Browse repository at this point
Copy the full SHA c2714b7View commit details
Commits on Aug 16, 2016
-
Bug fix AppendNonNil. Preserve input when errs list is empty.
When the filtered errs list has zero length then preserve the input error.
Configuration menu - View commit details
-
Copy full SHA for c966ec9 - Browse repository at this point
Copy the full SHA c966ec9View commit details
Commits on Aug 29, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 4ad7911 - Browse repository at this point
Copy the full SHA 4ad7911View commit details
Commits on Oct 19, 2016
-
Configuration menu - View commit details
-
Copy full SHA for a907df9 - Browse repository at this point
Copy the full SHA a907df9View commit details
Commits on Mar 9, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 5b98f73 - Browse repository at this point
Copy the full SHA 5b98f73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 065aa64 - Browse repository at this point
Copy the full SHA 065aa64View commit details
Commits on Nov 23, 2017
-
Configuration menu - View commit details
-
Copy full SHA for dd14681 - Browse repository at this point
Copy the full SHA dd14681View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea68e72 - Browse repository at this point
Copy the full SHA ea68e72View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.