Format nested multi-line errors neatly #30
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the default formatter function robust against errors which have nested
\n
characters.The overwhelmingly common case where an error is just one line is unaffected, so I presume this is backwards compatible in all cases where the current behavior is correct and desired.
I think this belongs in the default formatter rather than users having to plug it in because without this, any code that gives you an
error
in string form might have already "smudged" error information into ambiguous or hard-to-read form if that code used multierror and didn't proactively defend against the possibility of multi-line errors.