Add CircleCI & remove travis #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mwhooker
suggested changes
Oct 2, 2020
There was a problem hiding this comment.
Thanks, @mdeggies !
I notice travis uses make test testrace. Taking a look at the Makefile, both of those targets depend on generate. I'm not sure this project uses code generation, but to maintain behavior, it feels like we should run that first. Also, is there a way to get gotestsum to run with the race detector?
Also, could you please confirm there's a circleci project for this, and also update the badges in the readme from travis to circle? Thanks!
This was referenced Mar 11, 2021
Merged
Closed
Merged
Merged
Merged
Open
Open
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves from travis to CircleCI, using gotestsum for testing. Setup is very similar to those in other repos, see https://github.com/hashicorp/go-version as an example.
Tests pass locally using the latest version of go: