Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an interface declaration for Metrics #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bobbytables
Copy link

Also fixed some golint errors on the package level functions.

Purpose

Right now we use *metrics.Metrics as the type when we initialize things like servers or daemons with this package. This is fine in tests if you use a blackhole sink but it would be nice to just have something that guarantees the interface that we can implement ourselves for testing purposes. Since MockSink isn't exported. Alternatively we could just export the MockSink (its declared in a test file).

@bobbytables
Copy link
Author

Ping, any thoughts on this?

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants