Add an interface declaration for Metrics #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed some golint errors on the package level functions.
Purpose
Right now we use
*metrics.Metrics
as the type when we initialize things like servers or daemons with this package. This is fine in tests if you use a blackhole sink but it would be nice to just have something that guarantees the interface that we can implement ourselves for testing purposes. SinceMockSink
isn't exported. Alternatively we could just export the MockSink (its declared in a test file).