Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Shutdown to Metrics API #132

Merged
merged 3 commits into from Apr 26, 2022
Merged

Adds Shutdown to Metrics API #132

merged 3 commits into from Apr 26, 2022

Commits on Apr 14, 2022

  1. Adds Shutdown to Metrics API

    Short lived applications run the risk of losing metrics that are
    generated near the end of their lifetimes because MetricSinks can
    and do buffer data locally. The exact amount of data loss depends on
    MetricSink implementation, caller configuration, and the timing of
    the last metric sync.
    
    This adds a Shutdown function to the package API and the MetricSink
    interface. Shutdown flushes locally buffered data to storage, and
    then frees resources allocated to the MetricSink.
    
    Currently not all MetricSinks support exiting, and so resource
    release when calling Shutdown is best effort. Since Shutdown is
    intended for use immediately prior to application exit this is deemed
    acceptable, since resource leakage is minimized in this case.
    ggambetti committed Apr 14, 2022
    Copy the full SHA
    500c7d6 View commit details
    Browse the repository at this point in the history
  2. gofmt

    ggambetti committed Apr 14, 2022
    Copy the full SHA
    3e16282 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Copy the full SHA
    4fbf9d3 View commit details
    Browse the repository at this point in the history