New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add {Gauge,Summary,Counter}Definitions to PrometheusOpts to define non-expiring metrics #120
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
55fa26a
add static metrics to PrometheusSink
mkcp 1c0b6cf
fix a typo from merge conflict resolution
mkcp ff0aeb9
add fields for Help text
mkcp b74b130
add Help field to example
mkcp 8bad78f
unexport Prometheus{Counter,Gauge,Summary} and split fields into {Cou…
mkcp bc5d0a5
add docs and refactor range functions to be more legible
mkcp 73a313d
test the metricdefinitions
mkcp 8134248
fix the configuration for summaries created via SummaryDefinitions
mkcp af95c47
remove forced inits zeros and let the go prometheus lib take care of it
mkcp File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these classes were exported before (even though they didn't need to be), but i don't find any indication that they're used anywhere, so 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we looked over it and it seemed pretty safe to unexport these because they're only used internally.