Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When rendering multiple line output, still quote the individual lines #119

Merged
merged 1 commit into from Sep 21, 2022
Merged

When rendering multiple line output, still quote the individual lines #119

merged 1 commit into from Sep 21, 2022

Conversation

evanphx
Copy link
Contributor

@evanphx evanphx commented Sep 16, 2022

This also pulls over a specialized version of strconv.Quote for us to use.

@mcollao-hc mcollao-hc self-requested a review September 19, 2022 19:22
vancluever
vancluever approved these changes Sep 21, 2022
View reviewed changes
Copy link

@vancluever vancluever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Don't know if you want to add a test for the unprintable default case in writeEscapedForOutput, but yeah. 🙂

@evanphx evanphx merged commit 0d6179f into main Sep 21, 2022
@evanphx evanphx deleted the b-quoting branch September 21, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vancluever vancluever vancluever approved these changes

@mcollao-hc mcollao-hc mcollao-hc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evanphx @vancluever @mcollao-hc