Add support for custom timestamp. Closes #103

[binaek]

No description provided.

[hashicorp-cla]

All committers have signed the CLA.

[evanphx]

Is there a reason you'd want the logs in a different timezone than the system itself? That's the reason we don't do this currently, we want the logs to always reflect the time of the system.

[binaek]

@evanphx I put in the UTC behind a flag for precisely the reason you mentioned. Most logs need to reflect the time of the system where it's logged from.

Having said that, UTC as a time zone removes a lot of ambiguities associated with local time zones and timestamps (not even bringing DST into the picture)

However, the motivation behind this PR is that we use hclog inside a library - which runs in an application which has its own logging and can be setup to log in UTC. The logs from our library interleave with the application's log and appear in the same log destination.

[evanphx]

@binaek Gotcha, that makes sense. I'm wondering if rather than just a flag to set UTC, we should allow for someone to pass in a function that returns the current time. That would allow them maximum flexibility to calculate the current time in whatever form they want.

[binaek]

@evanphx That sounds like a good approach. Let me have a dig and update the PR.

[binaek]

@evanphx I have updated the PR with support for a custom time function - with a default which returns time.Now()

Take a look when you get the chance.

[evanphx]

Super minor bits, no need to create a closure here, can just use time.Now directly.

[binaek]

Huh! Not sure why I put the closure in there. Let me update the PR when I am at my desk

[binaek]

@evanphx PR updated

[binaek]

@evanphx let me know if you think this requires other changes