hds-clipboard modifier: convert to TypeScript (HDS-3344)
#2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KristinLBradley
force-pushed
the
hds-3344-clipboard-ts-conversion
branch
from
5b1ea6a
to
20a0df6
Compare
This was referenced May 20, 2024
didoo
reviewed
May 21, 2024
There was a problem hiding this comment.
@KristinLBradley I've left a few comments, but before approving I would like @alex-ju to do a check on the types I suggested to use yesterday, it may have not been the right suggestion (or at least, there may be further tweakings to do)
alex-ju
reviewed
May 21, 2024
…efined, define signature for modifier and use in default export
…in functions to avoid repetition
Co-authored-by: Alex <alex-ju@users.noreply.github.com> Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
KristinLBradley
force-pushed
the
hds-3344-clipboard-ts-conversion
branch
from
6c8f0fc
to
1f673a3
Compare
|
@KristinLBradley we did a session this morning with @alex-ju in which we reviewed multiple PRs related to TS and yours too; I hope you won't mind us pushing the commit e47d523 so we could get it approved and merged today |
Now that we test the target is an instance of HTMLElement, there's no need to check the node type
alex-ju
approved these changes
May 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR converts the
hds-clipboardmodifier to TypeScript.The clipboard modifier is used by:
CopyButton: convert to TypeScript (HDS-2688) #2100CopySnippet: convert to TypeScript (HDS-2689) #2110🔗 External links
Jira ticket: HDS-3344
👀 Component checklist
[ ] Percy was checked for any visual regression💬 Please consider using conventional comments when reviewing this PR.