Turn on typechecking for text component template in showcase #2107
+73
β52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
Example of how we can use showcase to check types as a consumer for HDS components. This PR opts into template typechecking for the Text component, and similar opt in could be done for showcase templates displaying any typed HDS components.
2 issues preventing this from being merged:
this.model
is void, even though route and controller are typed. I must be missing something as these docs indicate the type should be inferred based on route + controllerπ οΈ Detailed description
πΈ Screenshots
π External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
π Component checklist
π¬ Please consider using conventional comments when reviewing this PR.